Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Plan some kind of tests for EventTypeAppCardInterface and AppCard #11005

Closed
hariombalhara opened this issue Aug 29, 2023 · 3 comments
Closed
Assignees
Labels
app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar automated-tests area: unit tests, e2e tests, playwright 🧹 Improvements Improvements to existing features. Mostly UX/UI Low priority Created by Linear-GitHub Sync

Comments

@hariombalhara
Copy link
Member

hariombalhara commented Aug 29, 2023

EventTypeAppCardInterface and AppCard are common components used by all event type apps.

We need some kind of tests for this. Idea is to quickly do changes in them without needing to test all the apps that are using it. Goal is to be able to merge PRs like this with peace of mind
These are the apps using EventTypeAppCardInterface at the moment
Screenshot 2023-08-29 at 11 03 24 AM

Initially these tests can be component tests(like this) so that they are super quick to execute and let's see if we need to add e2e.

@maige-app maige-app bot added 🧹 Improvements Improvements to existing features. Mostly UX/UI automated-tests area: unit tests, e2e tests, playwright app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar labels Aug 29, 2023
@PeerRich PeerRich added the Low priority Created by Linear-GitHub Sync label Aug 30, 2023
@gitstart-app
Copy link
Contributor

gitstart-app bot commented Sep 4, 2023

Here is the GitStart Ticket for this issue: https://clients.gitstart.com/calcom/2711/tickets/CALCOM-11005

@memoryStack
Copy link

@hariombalhara is it still open ? I have some idea about test-cases for this component but i see that a similar issue has been marked as closed.

@keithwillcode
Copy link
Contributor

This was fixed as part of #11370

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar automated-tests area: unit tests, e2e tests, playwright 🧹 Improvements Improvements to existing features. Mostly UX/UI Low priority Created by Linear-GitHub Sync
Projects
None yet
Development

No branches or pull requests

5 participants