fix(color): read color from snowflake config

This allows the color of snowflakes to update properly after initialization
cahilfoley · Jun 9, 2019 · 60676a9 · 60676a9
1 parent 470f427
commit 60676a9
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 9 deletions.
diff --git a/lib/Snowflake.js b/lib/Snowflake.js
diff --git a/src/Snowfall.tsx b/src/Snowfall.tsx
@@ -57,7 +57,6 @@ const Snowfall = ({ color = '#dee4fd', snowflakeCount = 150, style }: SnowfallPr
   }, [render])
 
   useEffect(() => {
-    console.log('useEffect')
     loop()
     return () => cancelAnimationFrame(animationFrame.current)
   }, [loop])

diff --git a/src/Snowflake.ts b/src/Snowflake.ts
@@ -19,7 +19,6 @@ const defaultConfig: SnowflakeProps = {
 }
 
 interface SnowflakeParams {
-  color: string
   x: number
   y: number
   radius: number
@@ -40,9 +39,9 @@ class Snowflake {
     this.config = config
 
     // Setting initial parameters
-    const { color, radius, wind, speed } = this.fullConfig
+    const { radius, wind, speed } = this.fullConfig
+
     this.params = {
-      color,
       x: random(0, canvas.offsetWidth),
       y: random(-canvas.offsetHeight, 0),
       radius: random(...radius),
@@ -67,7 +66,7 @@ class Snowflake {
     if (ctx) {
       ctx.beginPath()
       ctx.arc(this.params.x, this.params.y, this.params.radius, 0, 2 * Math.PI)
-      ctx.fillStyle = this.params.color
+      ctx.fillStyle = this.fullConfig.color
       ctx.closePath()
       ctx.fill()
     }