Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend: Add nil check for every request #581

Closed
vancexu opened this issue Feb 26, 2018 · 1 comment
Closed

Frontend: Add nil check for every request #581

vancexu opened this issue Feb 26, 2018 · 1 comment
Assignees
@vancexu
Labels
bug

Comments

@vancexu
Copy link
Contributor

vancexu commented Feb 26, 2018

Currently in frontend APIs, we do not check if request arguments are nil or not.
So when someone call frontend directly without request arg, cadence will crash.

Frontend should check and ensure args are not nil before processing.
@vancexu vancexu added the bug label Feb 26, 2018
@vancexu vancexu mentioned this issue Feb 26, 2018
Closed
@vancexu vancexu self-assigned this Feb 26, 2018
@vancexu vancexu mentioned this issue Mar 27, 2018
Merged
@vancexu
Copy link
Contributor Author

vancexu commented Mar 30, 2018

#642

@vancexu vancexu closed this as completed Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vancexu vancexu

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vancexu