Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worker Host Session and Clean Shutdown for StickyTasklist #2369

Open
longquanzheng opened this issue Aug 12, 2019 · 1 comment
Open

Worker Host Session and Clean Shutdown for StickyTasklist #2369

longquanzheng opened this issue Aug 12, 2019 · 1 comment
Labels
customer Feature asks from customer feature New feature performance stability Server stability issues

Comments

@longquanzheng
Copy link
Contributor

With stickyTTL, expiring the sticky tasklists is very in-efficient, and the experience is not perfect : after worker host restarted, all the workflows in the cache have to wait for TTL. During the wait, lots of Querys and decisions are still scheduled to sticky tasklists and waiting to timeout.

Ideally, when worker host restarted, it should inform server(history engine) that the stickyTasklist is gone. So that any future activities/querys should not be scheduled to it.

We can keep a small LRU cache for thos "expired" session/stickyTaskList.

@longquanzheng longquanzheng added the feature New feature label Aug 12, 2019
@mfateev
Copy link
Contributor

mfateev commented Aug 12, 2019

Another option is to have task list itself marked as deleted and immediately refuse addTask requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer Feature asks from customer feature New feature performance stability Server stability issues
Projects
None yet
Development

No branches or pull requests

3 participants