Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a way to disable inline styles? #35

Closed
vkoves opened this issue Feb 13, 2020 · 2 comments · Fixed by #36
Closed

Is there a way to disable inline styles? #35

vkoves opened this issue Feb 13, 2020 · 2 comments · Fixed by #36

Comments

@vkoves
Copy link

vkoves commented Feb 13, 2020

I've recently setup mathquill4quill in an Angular project, and the button styling looks off due to how our app's default styles interface with mathquill4quill's styles. Here's a screenshot:

Screenshot from 2020-02-13 13-57-22

I was looking to override the mathquill4quill styles, but I noticed that they are all inline, making them really hard to override or modify. Is there a way to disable these inline styles so that I can custom style the operator buttons without using !important?

@c-w
Copy link
Owner

c-w commented Feb 14, 2020

@vkoves I opened #36 to make the styles injectable via a constructor argument:

const enableMathQuillFormulaAuthoring = window.mathquill4quill();

const quill = new Quill("#editor");

enableMathQuillFormulaAuthoring(quill, {
  styles: {
    mathquillInput: "...some css string here...",
    operatorButton: "...some css string here...",
    operatorContainer: "...some css string here...",
    latextInput: "...some css string here..."
  }
});

Could you take a look at the pull request and let me know if this fulfills your requirements?

@c-w c-w closed this as completed in #36 Feb 27, 2020
@c-w
Copy link
Owner

c-w commented Feb 27, 2020

A fix for this has been released in v2.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants