Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cranelift: wasmtime-jit-icache-coherence doesn't compile on FreeBSD #5308

Closed
bjorn3 opened this issue Nov 21, 2022 · 1 comment · Fixed by #5323
Closed

Cranelift: wasmtime-jit-icache-coherence doesn't compile on FreeBSD #5308

bjorn3 opened this issue Nov 21, 2022 · 1 comment · Fixed by #5323
Labels
bug Incorrect behavior in the current implementation that needs fixing cranelift Issues related to the Cranelift code generator

Comments

@bjorn3
Copy link
Contributor

bjorn3 commented Nov 21, 2022

This causes CI to fail for https://github.com/bjorn3/rustc_codegen_cranelift/pull/1295.

error[E0432]: unresolved import `libc`
 --> /.cargo/registry/src/github.jparrowsec.cn-1ecc6299db9ec823/wasmtime-jit-icache-coherence-2.0.0/src/libc.rs:3:5
  |
3 | use libc::{syscall, EINVAL, EPERM};
  |     ^^^^ help: a similar path exists: `crate::libc`
  |
  = note: `use` statements changed in Rust 2018; read more at <https://doc.rust-lang.org/edition-guide/rust-2018/module-system/path-clarity.html>

error[E0433]: failed to resolve: use of undeclared crate or module `libc`
 --> /.cargo/registry/src/github.jparrowsec.cn-1ecc6299db9ec823/wasmtime-jit-icache-coherence-2.0.0/src/libc.rs:7:30
  |
7 | const MEMBARRIER_CMD_GLOBAL: libc::c_int = 1;
  |                              ^^^^ use of undeclared crate or module `libc`

error[E0433]: failed to resolve: use of undeclared crate or module `libc`
 --> /.cargo/registry/src/github.jparrowsec.cn-1ecc6299db9ec823/wasmtime-jit-icache-coherence-2.0.0/src/libc.rs:8:51
  |
8 | const MEMBARRIER_CMD_PRIVATE_EXPEDITED_SYNC_CORE: libc::c_int = 32;
  |                                                   ^^^^ use of undeclared crate or module `libc`

error[E0433]: failed to resolve: use of undeclared crate or module `libc`
 --> /.cargo/registry/src/github.jparrowsec.cn-1ecc6299db9ec823/wasmtime-jit-icache-coherence-2.0.0/src/libc.rs:9:60
  |
9 | const MEMBARRIER_CMD_REGISTER_PRIVATE_EXPEDITED_SYNC_CORE: libc::c_int = 64;
  |                                                            ^^^^ use of undeclared crate or module `libc`
@bjorn3 bjorn3 added bug Incorrect behavior in the current implementation that needs fixing cranelift Issues related to the Cranelift code generator labels Nov 21, 2022
@cfallin
Copy link
Member

cfallin commented Nov 21, 2022

FreeBSD isn't an officially-supported platform but we can take patches on a best-effort basis. I'm happy to take a look if someone wants to make a PR (but I don't have a FreeBSD system handy to test it myself).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior in the current implementation that needs fixing cranelift Issues related to the Cranelift code generator
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants