You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The implementation of "command" modules in Linker will create a new Instance each time an export is invoked. This works well implementation-wise but it's also easy to leak memory and resources unintentionally. No Instance is actually deallocated until the Store is dropped, which means that commands are a vector for repeatedly creating instances by accident without ever actually deleting them.
I'm not really sure what the best way to handle this would be, but we should probably either document this or look into a fix!
The implementation of "command" modules in
Linker
will create a newInstance
each time an export is invoked. This works well implementation-wise but it's also easy to leak memory and resources unintentionally. NoInstance
is actually deallocated until theStore
is dropped, which means that commands are a vector for repeatedly creating instances by accident without ever actually deleting them.I'm not really sure what the best way to handle this would be, but we should probably either document this or look into a fix!
cc @sunfishcode
The text was updated successfully, but these errors were encountered: