Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide API for row right click #738

Closed
DamianOsipiuk opened this issue Jul 14, 2017 · 2 comments
Closed

Provide API for row right click #738

DamianOsipiuk opened this issue Jul 14, 2017 · 2 comments

Comments

@DamianOsipiuk
Copy link
Contributor

I need to make a context menu on row right click.
Instead of writing a row wrapper - which i did currently, i would like to pass onRowRightClick or onRowContextMenu (to be consistent with element event) to the table and get the event callback.

Implementing this is quite straightforward as i saw in code and should not take much time - i could provide a PR.

@bvaughn
Copy link
Owner

bvaughn commented Jul 14, 2017

I don't like continuing to add onRow* properties to Table. I wish I had designed that part of the API differently.

If you're willing to create a PR with all of the necessary code changes (to Table and defaultRowRenderer) and docs changes (Table.md), and it passes lint check, etc. I guess I'll merge it and it can go into the next release. 😄

I'm going to close this issue since I don't plan on taking action on it. But send a PR my way if you'd like!

@bvaughn bvaughn closed this as completed Jul 14, 2017
@ryb73
Copy link

ryb73 commented Aug 17, 2021

For anyone finding this from Google, this was implemented in #741, though it doesn't seem to have made it to the TypeScript defs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants