Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite loop #96

Open
yratanov opened this issue Dec 11, 2019 · 2 comments
Open

Infinite loop #96

yratanov opened this issue Dec 11, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@yratanov
Copy link

Hi all, is it possible to apply something like emberjs/ember-render-modifiers#16 to ember-render-helpers? I have infinite loop when using {{did-update}}.

@buschtoens
Copy link
Owner

Hey! :)

Unfortunately we can't do exactly the same thing as emberjs/ember-render-modifiers#16, since there is so HelperManager yet. However, maybe we can fix it still.

Can you please submit a failing test case or code snippet that demonstrates the infinite loop?

@buschtoens buschtoens added the bug Something isn't working label Dec 12, 2019
@yratanov
Copy link
Author

yratanov commented Dec 12, 2019

@buschtoens here is a demo repo:

https://github.com/yratanov/ember-render-helpers-infinite-loop/blob/master/app/templates/application.hbs
https://github.com/yratanov/ember-render-helpers-infinite-loop/blob/master/app/controllers/application.js

If I use @ember/render-modifiers it doesn't go to inifinite loop.

GitHub
ember-render-helpers infinite loop bug demo. Contribute to yratanov/ember-render-helpers-infinite-loop development by creating an account on GitHub.
GitHub
ember-render-helpers infinite loop bug demo. Contribute to yratanov/ember-render-helpers-infinite-loop development by creating an account on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants