From 2aa8c73bea9ef71e71b539f8c5fe96b027917f76 Mon Sep 17 00:00:00 2001 From: Steve Kirkland Date: Sat, 17 Apr 2021 22:36:25 +0100 Subject: [PATCH 1/9] Framework for build RN with latest native notifiers --- .buildkite/pipeline.yml | 13 +++++++++++++ docker-compose.yml | 2 +- dockerfiles/Dockerfile.publisher | 3 ++- scripts/common.js | 15 +++++++++++---- scripts/publish.js | 10 ++++++++++ 5 files changed, 37 insertions(+), 6 deletions(-) diff --git a/.buildkite/pipeline.yml b/.buildkite/pipeline.yml index 1b252d021..91be2ee87 100644 --- a/.buildkite/pipeline.yml +++ b/.buildkite/pipeline.yml @@ -27,6 +27,7 @@ steps: # Publish/package notifier # - label: ':docker: Prepare package.json' + if: build.env("RN_INTEGRATION") != null key: 'package-js' timeout_in_minutes: 3 plugins: @@ -41,11 +42,15 @@ steps: - docker-compose#v3.3.0: build: publisher image-repository: 855461928731.dkr.ecr.us-west-1.amazonaws.com/js + env: + RN_INTEGRATION: ${RN_INTEGRATION} + # # Trigger individual pipelines # - label: 'Trigger Browser pipeline' + if: build.env("RN_INTEGRATION") == null depends_on: 'package-js' trigger: 'bugsnag-js-browser' build: @@ -55,6 +60,7 @@ steps: async: true - label: 'Trigger Node pipeline' + if: build.env("RN_INTEGRATION") == null depends_on: 'package-js' trigger: 'bugsnag-js-node' build: @@ -64,6 +70,7 @@ steps: async: true - label: 'Trigger Expo pipeline' + if: build.env("RN_INTEGRATION") == null depends_on: 'publish-js' trigger: 'bugsnag-js-expo' build: @@ -84,6 +91,7 @@ steps: async: true - label: 'Trigger React Native CLI pipeline' + if: build.env("RN_INTEGRATION") == null depends_on: - 'publish-js' - 'android-builder-base' @@ -95,6 +103,7 @@ steps: async: true - label: ':aws-lambda: AWS Lambda tests' + if: build.env("RN_INTEGRATION") == null timeout_in_minutes: 35 agents: queue: 'opensource-mac-aws-sam' @@ -110,6 +119,7 @@ steps: # Core tests and checks # - label: ':docker: Build CI image' + if: build.env("RN_INTEGRATION") == null key: 'ci-image' depends_on: 'package-js' timeout_in_minutes: 20 @@ -129,6 +139,7 @@ steps: - ci:855461928731.dkr.ecr.us-west-1.amazonaws.com/js:ci-base - label: 'Lint' + if: build.env("RN_INTEGRATION") == null depends_on: 'ci-image' timeout_in_minutes: 10 plugins: @@ -137,6 +148,7 @@ steps: command: 'npm run test:lint' - label: 'Unit tests' + if: build.env("RN_INTEGRATION") == null depends_on: 'ci-image' timeout_in_minutes: 10 plugins: @@ -145,6 +157,7 @@ steps: command: 'npm run test:unit' - label: 'Type checks/tests' + if: build.env("RN_INTEGRATION") == null depends_on: 'ci-image' timeout_in_minutes: 10 plugins: diff --git a/docker-compose.yml b/docker-compose.yml index e41f1ff54..8bb5442f1 100644 --- a/docker-compose.yml +++ b/docker-compose.yml @@ -17,7 +17,7 @@ services: - REG_NPM_EMAIL - PUBLISH_URL - BRANCH_NAME - + - RN_INTEGRATION ci: build: context: . diff --git a/dockerfiles/Dockerfile.publisher b/dockerfiles/Dockerfile.publisher index e6f88fffc..abaa73783 100644 --- a/dockerfiles/Dockerfile.publisher +++ b/dockerfiles/Dockerfile.publisher @@ -21,4 +21,5 @@ COPY scripts/ scripts/ ARG PUBLISH_URL ARG BUILDKITE ARG BRANCH_NAME -RUN BUILDKITE=${BUILDKITE} BRANCH_NAME=${BRANCH_NAME} node scripts/publish.js $PUBLISH_URL +ARG RN_INTEGRATION +RUN BUILDKITE=${BUILDKITE} BRANCH_NAME=${BRANCH_NAME} RN_INTEGRATION=${RN_INTEGRATION} node scripts/publish.js $PUBLISH_URL diff --git a/scripts/common.js b/scripts/common.js index f3c5eaaf1..a8ec60043 100644 --- a/scripts/common.js +++ b/scripts/common.js @@ -30,12 +30,19 @@ module.exports = { branchName = this.run('git rev-parse --abbrev-ref HEAD').replace(regex, '-') } - // Distinguish from local use - const ciIndicator = (process.env.BUILDKITE ? 'ci-' : '') - // Get the current version from lerna.json const lernaVersion = lerna.version.match(/^[1-9][0-9]*\.[0-9]+\.[0-9]+/)[0] - return `${lernaVersion}-${ciIndicator}${branchName}.${commitId}` + // Base version for RN integration builds on the current time + if (process.env.RN_INTEGRATION) { + const timestamp = Math.round(Date.now() / 1000) + + return `${lernaVersion}-rn-integration.${timestamp}` + } else { + // Distinguish from local use + const ciIndicator = (process.env.BUILDKITE ? 'ci-' : '') + + return `${lernaVersion}-${ciIndicator}${branchName}.${commitId}` + } } } diff --git a/scripts/publish.js b/scripts/publish.js index a4af4e8c5..378f9964f 100755 --- a/scripts/publish.js +++ b/scripts/publish.js @@ -15,6 +15,16 @@ function publish (publishUrl) { } if (myVersions.length === 0) { + // TODO if (process.env.RN_INTEGRATION) { + if (true) { + // For RN integration builds, dynamically update the native notifiers + common.changeDir('packages/react-native') + common.run('./update-android.sh --sha next', true) + common.run('./update-ios.sh --sha next', true) + common.changeDir('../..') + } + + // Build and publish packages console.log(`Publishing as '${version}'`) common.run('npm install', true) From 5fd6e20255daf0e732580236f9071d15da47acf6 Mon Sep 17 00:00:00 2001 From: Steve Kirkland Date: Sat, 17 Apr 2021 22:42:53 +0100 Subject: [PATCH 2/9] Add rsync to image --- dockerfiles/Dockerfile.publisher | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dockerfiles/Dockerfile.publisher b/dockerfiles/Dockerfile.publisher index abaa73783..7a020457b 100644 --- a/dockerfiles/Dockerfile.publisher +++ b/dockerfiles/Dockerfile.publisher @@ -1,7 +1,7 @@ # CI test image for unit/lint/type tests FROM node:lts-alpine -RUN apk add --update bash git curl +RUN apk add --update bash git curl rsync RUN rm -f ~/.npmrc From a7ceec85f28e05bc25a8f7ddda607681a58e9fc5 Mon Sep 17 00:00:00 2001 From: Steve Kirkland Date: Sun, 18 Apr 2021 21:08:48 +0100 Subject: [PATCH 3/9] Need Java to dynamically build Android --- dockerfiles/Dockerfile.publisher | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/dockerfiles/Dockerfile.publisher b/dockerfiles/Dockerfile.publisher index 7a020457b..230b73c10 100644 --- a/dockerfiles/Dockerfile.publisher +++ b/dockerfiles/Dockerfile.publisher @@ -1,5 +1,27 @@ # CI test image for unit/lint/type tests -FROM node:lts-alpine +#FROM node:lts-alpine +# +#RUN apk add --update bash git rsync + +FROM openjdk:8-jdk-buster + +# OS setup +RUN curl -sL https://deb.nodesource.com/setup_10.x | bash - +RUN apt-get update && apt-get install -y gradle jq git-core build-essential openssl libssl-dev bash git rsync nodejs + +# Android tools +WORKDIR /sdk +RUN wget https://dl.google.com/android/repository/sdk-tools-linux-4333796.zip -q \ + && unzip -q sdk-tools-linux-4333796.zip \ + && rm sdk-tools-linux-4333796.zip + +ENV PATH="${PATH}:/sdk/tools:/sdk/tools/bin" + +RUN yes | sdkmanager "platform-tools" "build-tools;28.0.3" +ENV PATH="${PATH}:/sdk/platform-tools" + +ENV ANDROID_HOME="/sdk/" +ENV GRADLE_OPTS="-Dorg.gradle.daemon=false" RUN apk add --update bash git curl rsync From 0e8229206ec91c77529e1617bcf78a11bf7ed6ba Mon Sep 17 00:00:00 2001 From: Steve Kirkland Date: Thu, 22 Apr 2021 12:46:05 +0100 Subject: [PATCH 4/9] No longer using Alpine --- dockerfiles/Dockerfile.publisher | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/dockerfiles/Dockerfile.publisher b/dockerfiles/Dockerfile.publisher index 230b73c10..bcc781dda 100644 --- a/dockerfiles/Dockerfile.publisher +++ b/dockerfiles/Dockerfile.publisher @@ -1,13 +1,10 @@ -# CI test image for unit/lint/type tests -#FROM node:lts-alpine -# -#RUN apk add --update bash git rsync - +# CI test image for unit/lint/type tests, but also needs to be capable of building +# the Android notifier as part of a React Native integration test run. FROM openjdk:8-jdk-buster # OS setup RUN curl -sL https://deb.nodesource.com/setup_10.x | bash - -RUN apt-get update && apt-get install -y gradle jq git-core build-essential openssl libssl-dev bash git rsync nodejs +RUN apt-get update && apt-get install -y gradle jq git-core build-essential openssl libssl-dev bash curl git rsync nodejs # Android tools WORKDIR /sdk @@ -23,8 +20,6 @@ ENV PATH="${PATH}:/sdk/platform-tools" ENV ANDROID_HOME="/sdk/" ENV GRADLE_OPTS="-Dorg.gradle.daemon=false" -RUN apk add --update bash git curl rsync - RUN rm -f ~/.npmrc ARG REG_BASIC_CREDENTIAL From 2637c62fe21bf31057f876be45bfb5ec0917026e Mon Sep 17 00:00:00 2001 From: Steve Kirkland Date: Thu, 22 Apr 2021 17:34:10 +0100 Subject: [PATCH 5/9] =?UTF-8?q?Use=20android=E2=80=99s=20base=20image?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- dockerfiles/Dockerfile.publisher | 21 +++++++-------------- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/dockerfiles/Dockerfile.publisher b/dockerfiles/Dockerfile.publisher index bcc781dda..7ff1c0fc6 100644 --- a/dockerfiles/Dockerfile.publisher +++ b/dockerfiles/Dockerfile.publisher @@ -1,25 +1,18 @@ # CI test image for unit/lint/type tests, but also needs to be capable of building # the Android notifier as part of a React Native integration test run. -FROM openjdk:8-jdk-buster +FROM 855461928731.dkr.ecr.us-west-1.amazonaws.com/android:latest as android -# OS setup -RUN curl -sL https://deb.nodesource.com/setup_10.x | bash - -RUN apt-get update && apt-get install -y gradle jq git-core build-essential openssl libssl-dev bash curl git rsync nodejs - -# Android tools -WORKDIR /sdk -RUN wget https://dl.google.com/android/repository/sdk-tools-linux-4333796.zip -q \ - && unzip -q sdk-tools-linux-4333796.zip \ - && rm sdk-tools-linux-4333796.zip +RUN DEBIAN_FRONTEND=noninteractive apt-get install -y rsync nodejs -ENV PATH="${PATH}:/sdk/tools:/sdk/tools/bin" - -RUN yes | sdkmanager "platform-tools" "build-tools;28.0.3" -ENV PATH="${PATH}:/sdk/platform-tools" +# OS setup +#RUN curl -sL https://deb.nodesource.com/setup_10.x | bash - +#RUN apt-get update && apt-get install -y gradle jq git-core build-essential openssl libssl-dev bash curl git rsync nodejs +# Android setup ENV ANDROID_HOME="/sdk/" ENV GRADLE_OPTS="-Dorg.gradle.daemon=false" +# NPM setup RUN rm -f ~/.npmrc ARG REG_BASIC_CREDENTIAL From 27ce42578cdc05c90f8bd59abd16513c38478046 Mon Sep 17 00:00:00 2001 From: Steve Kirkland Date: Thu, 22 Apr 2021 17:37:06 +0100 Subject: [PATCH 6/9] Need npm --- dockerfiles/Dockerfile.publisher | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dockerfiles/Dockerfile.publisher b/dockerfiles/Dockerfile.publisher index 7ff1c0fc6..1ab4224ec 100644 --- a/dockerfiles/Dockerfile.publisher +++ b/dockerfiles/Dockerfile.publisher @@ -2,7 +2,7 @@ # the Android notifier as part of a React Native integration test run. FROM 855461928731.dkr.ecr.us-west-1.amazonaws.com/android:latest as android -RUN DEBIAN_FRONTEND=noninteractive apt-get install -y rsync nodejs +RUN DEBIAN_FRONTEND=noninteractive apt-get update && apt-get install -y rsync npm nodejs # OS setup #RUN curl -sL https://deb.nodesource.com/setup_10.x | bash - From 383494bcf888fdc58546894b79351a7779146dec Mon Sep 17 00:00:00 2001 From: Steve Kirkland Date: Thu, 22 Apr 2021 18:32:14 +0100 Subject: [PATCH 7/9] Enable schedule driven testing --- dockerfiles/Dockerfile.publisher | 4 ---- scripts/publish.js | 3 +-- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/dockerfiles/Dockerfile.publisher b/dockerfiles/Dockerfile.publisher index 1ab4224ec..193161fda 100644 --- a/dockerfiles/Dockerfile.publisher +++ b/dockerfiles/Dockerfile.publisher @@ -4,10 +4,6 @@ FROM 855461928731.dkr.ecr.us-west-1.amazonaws.com/android:latest as android RUN DEBIAN_FRONTEND=noninteractive apt-get update && apt-get install -y rsync npm nodejs -# OS setup -#RUN curl -sL https://deb.nodesource.com/setup_10.x | bash - -#RUN apt-get update && apt-get install -y gradle jq git-core build-essential openssl libssl-dev bash curl git rsync nodejs - # Android setup ENV ANDROID_HOME="/sdk/" ENV GRADLE_OPTS="-Dorg.gradle.daemon=false" diff --git a/scripts/publish.js b/scripts/publish.js index 378f9964f..1d8838ae3 100755 --- a/scripts/publish.js +++ b/scripts/publish.js @@ -15,8 +15,7 @@ function publish (publishUrl) { } if (myVersions.length === 0) { - // TODO if (process.env.RN_INTEGRATION) { - if (true) { + if (process.env.RN_INTEGRATION) { // For RN integration builds, dynamically update the native notifiers common.changeDir('packages/react-native') common.run('./update-android.sh --sha next', true) From 1799f90306a3cc51e2bf154276ff9daa58b5cf9b Mon Sep 17 00:00:00 2001 From: Steve Kirkland Date: Thu, 22 Apr 2021 18:35:17 +0100 Subject: [PATCH 8/9] Correct pipeline conditions --- .buildkite/pipeline.yml | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/.buildkite/pipeline.yml b/.buildkite/pipeline.yml index 91be2ee87..344748e3e 100644 --- a/.buildkite/pipeline.yml +++ b/.buildkite/pipeline.yml @@ -27,7 +27,7 @@ steps: # Publish/package notifier # - label: ':docker: Prepare package.json' - if: build.env("RN_INTEGRATION") != null + if: build.env("RN_INTEGRATION") != "true" key: 'package-js' timeout_in_minutes: 3 plugins: @@ -50,7 +50,7 @@ steps: # Trigger individual pipelines # - label: 'Trigger Browser pipeline' - if: build.env("RN_INTEGRATION") == null + if: build.env("RN_INTEGRATION") != "true" depends_on: 'package-js' trigger: 'bugsnag-js-browser' build: @@ -60,7 +60,7 @@ steps: async: true - label: 'Trigger Node pipeline' - if: build.env("RN_INTEGRATION") == null + if: build.env("RN_INTEGRATION") != "true" depends_on: 'package-js' trigger: 'bugsnag-js-node' build: @@ -70,7 +70,7 @@ steps: async: true - label: 'Trigger Expo pipeline' - if: build.env("RN_INTEGRATION") == null + if: build.env("RN_INTEGRATION") != "true" depends_on: 'publish-js' trigger: 'bugsnag-js-expo' build: @@ -91,7 +91,7 @@ steps: async: true - label: 'Trigger React Native CLI pipeline' - if: build.env("RN_INTEGRATION") == null + if: build.env("RN_INTEGRATION") != "true" depends_on: - 'publish-js' - 'android-builder-base' @@ -103,7 +103,7 @@ steps: async: true - label: ':aws-lambda: AWS Lambda tests' - if: build.env("RN_INTEGRATION") == null + if: build.env("RN_INTEGRATION") != "true" timeout_in_minutes: 35 agents: queue: 'opensource-mac-aws-sam' @@ -119,7 +119,7 @@ steps: # Core tests and checks # - label: ':docker: Build CI image' - if: build.env("RN_INTEGRATION") == null + if: build.env("RN_INTEGRATION") != "true" key: 'ci-image' depends_on: 'package-js' timeout_in_minutes: 20 @@ -139,7 +139,7 @@ steps: - ci:855461928731.dkr.ecr.us-west-1.amazonaws.com/js:ci-base - label: 'Lint' - if: build.env("RN_INTEGRATION") == null + if: build.env("RN_INTEGRATION") != "true" depends_on: 'ci-image' timeout_in_minutes: 10 plugins: @@ -148,7 +148,7 @@ steps: command: 'npm run test:lint' - label: 'Unit tests' - if: build.env("RN_INTEGRATION") == null + if: build.env("RN_INTEGRATION") != "true" depends_on: 'ci-image' timeout_in_minutes: 10 plugins: @@ -157,7 +157,7 @@ steps: command: 'npm run test:unit' - label: 'Type checks/tests' - if: build.env("RN_INTEGRATION") == null + if: build.env("RN_INTEGRATION") != "true" depends_on: 'ci-image' timeout_in_minutes: 10 plugins: From 066497b874e649b5509ae30cd9e2c5a420a07bdb Mon Sep 17 00:00:00 2001 From: Steve Kirkland Date: Wed, 28 Apr 2021 08:03:51 +0100 Subject: [PATCH 9/9] Update environment variable to be more descriptive --- .buildkite/pipeline.yml | 22 +++++++++++----------- docker-compose.yml | 2 +- dockerfiles/Dockerfile.publisher | 4 ++-- scripts/common.js | 2 +- scripts/publish.js | 2 +- 5 files changed, 16 insertions(+), 16 deletions(-) diff --git a/.buildkite/pipeline.yml b/.buildkite/pipeline.yml index 344748e3e..f4d85eff4 100644 --- a/.buildkite/pipeline.yml +++ b/.buildkite/pipeline.yml @@ -27,7 +27,7 @@ steps: # Publish/package notifier # - label: ':docker: Prepare package.json' - if: build.env("RN_INTEGRATION") != "true" + if: build.env("BUILD_RN_WITH_LATEST_NATIVES") != "true" key: 'package-js' timeout_in_minutes: 3 plugins: @@ -43,14 +43,14 @@ steps: build: publisher image-repository: 855461928731.dkr.ecr.us-west-1.amazonaws.com/js env: - RN_INTEGRATION: ${RN_INTEGRATION} + BUILD_RN_WITH_LATEST_NATIVES: ${BUILD_RN_WITH_LATEST_NATIVES} # # Trigger individual pipelines # - label: 'Trigger Browser pipeline' - if: build.env("RN_INTEGRATION") != "true" + if: build.env("BUILD_RN_WITH_LATEST_NATIVES") != "true" depends_on: 'package-js' trigger: 'bugsnag-js-browser' build: @@ -60,7 +60,7 @@ steps: async: true - label: 'Trigger Node pipeline' - if: build.env("RN_INTEGRATION") != "true" + if: build.env("BUILD_RN_WITH_LATEST_NATIVES") != "true" depends_on: 'package-js' trigger: 'bugsnag-js-node' build: @@ -70,7 +70,7 @@ steps: async: true - label: 'Trigger Expo pipeline' - if: build.env("RN_INTEGRATION") != "true" + if: build.env("BUILD_RN_WITH_LATEST_NATIVES") != "true" depends_on: 'publish-js' trigger: 'bugsnag-js-expo' build: @@ -91,7 +91,7 @@ steps: async: true - label: 'Trigger React Native CLI pipeline' - if: build.env("RN_INTEGRATION") != "true" + if: build.env("BUILD_RN_WITH_LATEST_NATIVES") != "true" depends_on: - 'publish-js' - 'android-builder-base' @@ -103,7 +103,7 @@ steps: async: true - label: ':aws-lambda: AWS Lambda tests' - if: build.env("RN_INTEGRATION") != "true" + if: build.env("BUILD_RN_WITH_LATEST_NATIVES") != "true" timeout_in_minutes: 35 agents: queue: 'opensource-mac-aws-sam' @@ -119,7 +119,7 @@ steps: # Core tests and checks # - label: ':docker: Build CI image' - if: build.env("RN_INTEGRATION") != "true" + if: build.env("BUILD_RN_WITH_LATEST_NATIVES") != "true" key: 'ci-image' depends_on: 'package-js' timeout_in_minutes: 20 @@ -139,7 +139,7 @@ steps: - ci:855461928731.dkr.ecr.us-west-1.amazonaws.com/js:ci-base - label: 'Lint' - if: build.env("RN_INTEGRATION") != "true" + if: build.env("BUILD_RN_WITH_LATEST_NATIVES") != "true" depends_on: 'ci-image' timeout_in_minutes: 10 plugins: @@ -148,7 +148,7 @@ steps: command: 'npm run test:lint' - label: 'Unit tests' - if: build.env("RN_INTEGRATION") != "true" + if: build.env("BUILD_RN_WITH_LATEST_NATIVES") != "true" depends_on: 'ci-image' timeout_in_minutes: 10 plugins: @@ -157,7 +157,7 @@ steps: command: 'npm run test:unit' - label: 'Type checks/tests' - if: build.env("RN_INTEGRATION") != "true" + if: build.env("BUILD_RN_WITH_LATEST_NATIVES") != "true" depends_on: 'ci-image' timeout_in_minutes: 10 plugins: diff --git a/docker-compose.yml b/docker-compose.yml index 8bb5442f1..7ec174b65 100644 --- a/docker-compose.yml +++ b/docker-compose.yml @@ -17,7 +17,7 @@ services: - REG_NPM_EMAIL - PUBLISH_URL - BRANCH_NAME - - RN_INTEGRATION + - BUILD_RN_WITH_LATEST_NATIVES ci: build: context: . diff --git a/dockerfiles/Dockerfile.publisher b/dockerfiles/Dockerfile.publisher index 193161fda..bc41ddb0d 100644 --- a/dockerfiles/Dockerfile.publisher +++ b/dockerfiles/Dockerfile.publisher @@ -27,5 +27,5 @@ COPY scripts/ scripts/ ARG PUBLISH_URL ARG BUILDKITE ARG BRANCH_NAME -ARG RN_INTEGRATION -RUN BUILDKITE=${BUILDKITE} BRANCH_NAME=${BRANCH_NAME} RN_INTEGRATION=${RN_INTEGRATION} node scripts/publish.js $PUBLISH_URL +ARG BUILD_RN_WITH_LATEST_NATIVES +RUN BUILDKITE=${BUILDKITE} BRANCH_NAME=${BRANCH_NAME} BUILD_RN_WITH_LATEST_NATIVES=${BUILD_RN_WITH_LATEST_NATIVES} node scripts/publish.js $PUBLISH_URL diff --git a/scripts/common.js b/scripts/common.js index a8ec60043..8f2e5de12 100644 --- a/scripts/common.js +++ b/scripts/common.js @@ -34,7 +34,7 @@ module.exports = { const lernaVersion = lerna.version.match(/^[1-9][0-9]*\.[0-9]+\.[0-9]+/)[0] // Base version for RN integration builds on the current time - if (process.env.RN_INTEGRATION) { + if (process.env.BUILD_RN_WITH_LATEST_NATIVES) { const timestamp = Math.round(Date.now() / 1000) return `${lernaVersion}-rn-integration.${timestamp}` diff --git a/scripts/publish.js b/scripts/publish.js index 1d8838ae3..549f77e65 100755 --- a/scripts/publish.js +++ b/scripts/publish.js @@ -15,7 +15,7 @@ function publish (publishUrl) { } if (myVersions.length === 0) { - if (process.env.RN_INTEGRATION) { + if (process.env.BUILD_RN_WITH_LATEST_NATIVES) { // For RN integration builds, dynamically update the native notifiers common.changeDir('packages/react-native') common.run('./update-android.sh --sha next', true)