From 843fe562d492e0f8324fcdff45ab0cd75da607fc Mon Sep 17 00:00:00 2001 From: Steve Kirkland Date: Tue, 13 Oct 2020 18:39:40 +0100 Subject: [PATCH 1/5] style(config): bring react native test fixtures into linting scope --- .eslintignore | 7 +++++-- test/react-native/features/fixtures/rn0.60/.eslintrc.js | 4 ---- test/react-native/features/fixtures/rn0.63/.eslintrc.js | 4 ---- 3 files changed, 5 insertions(+), 10 deletions(-) delete mode 100644 test/react-native/features/fixtures/rn0.60/.eslintrc.js delete mode 100644 test/react-native/features/fixtures/rn0.63/.eslintrc.js diff --git a/.eslintignore b/.eslintignore index a126f677b5..975c51a9b7 100644 --- a/.eslintignore +++ b/.eslintignore @@ -1,9 +1,12 @@ dist examples -features **/node_modules/** -fixtures scratch coverage packages/core/types/test/*.js packages/react-native/android/build/reports +packages/**/features +packages/**/fixtures +test/browser +test/expo +test/node diff --git a/test/react-native/features/fixtures/rn0.60/.eslintrc.js b/test/react-native/features/fixtures/rn0.60/.eslintrc.js deleted file mode 100644 index 40c6dcd05f..0000000000 --- a/test/react-native/features/fixtures/rn0.60/.eslintrc.js +++ /dev/null @@ -1,4 +0,0 @@ -module.exports = { - root: true, - extends: '@react-native-community', -}; diff --git a/test/react-native/features/fixtures/rn0.63/.eslintrc.js b/test/react-native/features/fixtures/rn0.63/.eslintrc.js deleted file mode 100644 index 40c6dcd05f..0000000000 --- a/test/react-native/features/fixtures/rn0.63/.eslintrc.js +++ /dev/null @@ -1,4 +0,0 @@ -module.exports = { - root: true, - extends: '@react-native-community', -}; From 6cbbf3b5ea2d29df72f2614982a58e08b4c51a8c Mon Sep 17 00:00:00 2001 From: Steve Kirkland Date: Tue, 13 Oct 2020 21:27:23 +0100 Subject: [PATCH 2/5] style(tests): resolve lint violations --- ...ctNavigationBreadcrumbsDisabledScenario.js | 4 +- ...actNavigationBreadcrumbsEnabledScenario.js | 3 +- .../scenarios/Scenario.js | 8 +-- .../screens/Details.js | 22 ++++---- .../screens/Home.js | 26 +++++----- .../app/react_navigation_js/app/App.js | 22 ++++---- ...ctNavigationBreadcrumbsDisabledScenario.js | 52 ++++++++++--------- ...actNavigationBreadcrumbsEnabledScenario.js | 45 ++++++++-------- .../app/scenarios/Scenario.js | 8 +-- .../fixtures/app/react_navigation_js/index.js | 10 ++-- .../app/scenarios/AppConfigAppTypeScenario.js | 4 +- 11 files changed, 105 insertions(+), 99 deletions(-) diff --git a/test/react-native/features/fixtures/app/react_native_navigation_js/scenarios/ReactNavigationBreadcrumbsDisabledScenario.js b/test/react-native/features/fixtures/app/react_native_navigation_js/scenarios/ReactNavigationBreadcrumbsDisabledScenario.js index 1a3a600154..e6f44b38d3 100644 --- a/test/react-native/features/fixtures/app/react_native_navigation_js/scenarios/ReactNavigationBreadcrumbsDisabledScenario.js +++ b/test/react-native/features/fixtures/app/react_native_navigation_js/scenarios/ReactNavigationBreadcrumbsDisabledScenario.js @@ -1,8 +1,8 @@ import Scenario from './Scenario' export class ReactNavigationBreadcrumbsDisabledScenario extends Scenario { - constructor(configuration, extraData, jsConfig) { + constructor (configuration, extraData, jsConfig) { super() configuration.enabledBreadcrumbTypes = [] } -} \ No newline at end of file +} diff --git a/test/react-native/features/fixtures/app/react_native_navigation_js/scenarios/ReactNavigationBreadcrumbsEnabledScenario.js b/test/react-native/features/fixtures/app/react_native_navigation_js/scenarios/ReactNavigationBreadcrumbsEnabledScenario.js index c72b779d32..a4657fe72e 100644 --- a/test/react-native/features/fixtures/app/react_native_navigation_js/scenarios/ReactNavigationBreadcrumbsEnabledScenario.js +++ b/test/react-native/features/fixtures/app/react_native_navigation_js/scenarios/ReactNavigationBreadcrumbsEnabledScenario.js @@ -1,3 +1,4 @@ import Scenario from './Scenario' -export class ReactNavigationBreadcrumbsEnabledScenario extends Scenario {} \ No newline at end of file +export class ReactNavigationBreadcrumbsEnabledScenario extends Scenario { +} diff --git a/test/react-native/features/fixtures/app/react_native_navigation_js/scenarios/Scenario.js b/test/react-native/features/fixtures/app/react_native_navigation_js/scenarios/Scenario.js index 4651f7a089..7b61ba40c5 100644 --- a/test/react-native/features/fixtures/app/react_native_navigation_js/scenarios/Scenario.js +++ b/test/react-native/features/fixtures/app/react_native_navigation_js/scenarios/Scenario.js @@ -1,8 +1,8 @@ export default class Scenario { - constructor(configuration, extraData, jsConfig) {} - run() {} + run () { + } - timeout(ms) { - return new Promise(resolve => setTimeout(resolve, ms)); + timeout (ms) { + return new Promise(resolve => setTimeout(resolve, ms)) } } diff --git a/test/react-native/features/fixtures/app/react_native_navigation_js/screens/Details.js b/test/react-native/features/fixtures/app/react_native_navigation_js/screens/Details.js index 07f343a4a4..c55d32262a 100644 --- a/test/react-native/features/fixtures/app/react_native_navigation_js/screens/Details.js +++ b/test/react-native/features/fixtures/app/react_native_navigation_js/screens/Details.js @@ -1,6 +1,6 @@ -import * as React from 'react'; -import {View, Text, Button} from 'react-native'; -import {Navigation} from 'react-native-navigation'; +import * as React from 'react' +import { View, Text, Button } from 'react-native' +import { Navigation } from 'react-native-navigation' import Bugsnag from '@bugsnag/react-native' const DetailsScreen = (props) => { @@ -11,18 +11,20 @@ const DetailsScreen = (props) => { accessibilityLabel='navigate' onPress={() => Navigation.pop(props.componentId) - } /> + }/>