From 5dd288a0bc694746c04ff1659d9c22228bad76e8 Mon Sep 17 00:00:00 2001 From: fractalwrench Date: Thu, 23 Jul 2020 10:13:12 +0100 Subject: [PATCH] fix: prevent duplicate notifier dependencies being added --- .../src/main/java/com/bugsnag/android/Notifier.kt | 2 +- .../test/java/com/bugsnag/android/NotifierSerializationTest.kt | 2 +- .../main/java/com/bugsnag/android/BugsnagReactNativePlugin.kt | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/bugsnag-android-core/src/main/java/com/bugsnag/android/Notifier.kt b/bugsnag-android-core/src/main/java/com/bugsnag/android/Notifier.kt index ac52797e22..fd510c8532 100644 --- a/bugsnag-android-core/src/main/java/com/bugsnag/android/Notifier.kt +++ b/bugsnag-android-core/src/main/java/com/bugsnag/android/Notifier.kt @@ -11,7 +11,7 @@ class Notifier @JvmOverloads constructor( var url: String = "https://bugsnag.com" ) : JsonStream.Streamable { - val dependencies = mutableListOf() + var dependencies = listOf() @Throws(IOException::class) override fun toStream(writer: JsonStream) { diff --git a/bugsnag-android-core/src/test/java/com/bugsnag/android/NotifierSerializationTest.kt b/bugsnag-android-core/src/test/java/com/bugsnag/android/NotifierSerializationTest.kt index ca010bc571..67bb8c8dc6 100644 --- a/bugsnag-android-core/src/test/java/com/bugsnag/android/NotifierSerializationTest.kt +++ b/bugsnag-android-core/src/test/java/com/bugsnag/android/NotifierSerializationTest.kt @@ -23,7 +23,7 @@ internal class NotifierSerializationTest { deps.version = "4.5.6" deps.name = "CustomNotifier" deps.url = "https://example.com" - deps.dependencies.add(notifier) + deps.dependencies = listOf(notifier) return generateSerializationTestCases("notifier", notifier, deps) } } diff --git a/bugsnag-plugin-react-native/src/main/java/com/bugsnag/android/BugsnagReactNativePlugin.kt b/bugsnag-plugin-react-native/src/main/java/com/bugsnag/android/BugsnagReactNativePlugin.kt index 34424d53b5..f155762d8e 100644 --- a/bugsnag-plugin-react-native/src/main/java/com/bugsnag/android/BugsnagReactNativePlugin.kt +++ b/bugsnag-plugin-react-native/src/main/java/com/bugsnag/android/BugsnagReactNativePlugin.kt @@ -51,7 +51,7 @@ class BugsnagReactNativePlugin : Plugin { notifier.name = "Bugsnag React Native" notifier.url = "https://github.com/bugsnag/bugsnag-js" notifier.version = jsVersion - notifier.dependencies.add(Notifier()) // depend on bugsnag-android + client.notifier.dependencies = listOf(Notifier()) // depend on bugsnag-android } private fun ignoreJavaScriptExceptions() {