Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace golang.org/x/exp with stdlib #3603

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Conversation

Juneezee
Copy link
Contributor

The experimental functions in golang.org/x/exp are now available in the standard library in Go 1.21.

Reference: https://go.dev/doc/go1.21#slices
Reference: https://go.dev/doc/go1.21#cmp

@CLAassistant
Copy link

CLAassistant commented Jan 22, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@doriable doriable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this up! :) Checked everything locally, you'll need to run make generate and merge in main, but otherwise it looks good!

The experimental functions in `golang.org/x/exp` are now
available in the standard library in Go 1.21.

Reference: https://go.dev/doc/go1.21#slices
Reference: https://go.dev/doc/go1.21#cmp
Signed-off-by: Eng Zer Jun <[email protected]>
@Juneezee
Copy link
Contributor Author

@doriable Thanks for reviewing this PR! Please take a look again. Thanks! 😊

Copy link
Member

@doriable doriable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes so quickly, everything looks good! Going to approve and merge.

@doriable doriable merged commit 725301b into bufbuild:main Jan 30, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants