From 11896b96f969166feb6b0dfd2e91a99dcf870bba Mon Sep 17 00:00:00 2001 From: Mike Ryan Date: Fri, 11 Mar 2022 16:44:24 -0600 Subject: [PATCH] Update minio-go - fix for s3 IAM auth delays - Update minio-go so that we can get a fix for timeouts encountered when trying to retrieve IMDSv2 tokens during IAM s3 authentication. When bazel-remote is run within a container on an aws ec2 instance, initial attempts to authenticate using IAM will encounter a 120s delay. The issue is the result of changes in the ec2 metadata services with IMDSv2, which restricts how many network hops may be incurred before for PUT statements. When executing directly on the ec2 instance, it is 1 hop away, and is allowed. When executing within a docker container on an ec2 instance, it is 2 hops away, and is forbidden. The change to minio go reduces the timeout from 120s to 1s. Apparently this token request is optional, so things continue to work afterward, regardless. https://github.com/minio/minio-go/pull/1626 --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 3b2618fe9..855f4e2d8 100644 --- a/go.mod +++ b/go.mod @@ -10,7 +10,7 @@ require ( github.com/google/uuid v1.3.0 github.com/grpc-ecosystem/go-grpc-prometheus v1.2.0 github.com/klauspost/compress v1.14.1 - github.com/minio/minio-go/v7 v7.0.20 + github.com/minio/minio-go/v7 v7.0.24-0.20220302185830-f2d40be3e82f github.com/mostynb/go-grpc-compression v1.1.16 github.com/mostynb/zstdpool-syncpool v0.0.12 github.com/prometheus/client_golang v1.11.0 diff --git a/go.sum b/go.sum index 8652352ef..e9951ddaf 100644 --- a/go.sum +++ b/go.sum @@ -265,6 +265,8 @@ github.com/minio/md5-simd v1.1.2 h1:Gdi1DZK69+ZVMoNHRXJyNcxrMA4dSxoYHZSQbirFg34= github.com/minio/md5-simd v1.1.2/go.mod h1:MzdKDxYpY2BT9XQFocsiZf/NKVtR7nkE4RoEpN+20RM= github.com/minio/minio-go/v7 v7.0.20 h1:0+Xt1SkCKDgcx5cmo3UxXcJ37u5Gy+/2i/+eQYqmYJw= github.com/minio/minio-go/v7 v7.0.20/go.mod h1:ei5JjmxwHaMrgsMrn4U/+Nmg+d8MKS1U2DAn1ou4+Do= +github.com/minio/minio-go/v7 v7.0.24-0.20220302185830-f2d40be3e82f h1:5+NaPkyAjRvzl81ZN3N7VgMYsQwbYwnj3NQ2CJpxwX0= +github.com/minio/minio-go/v7 v7.0.24-0.20220302185830-f2d40be3e82f/go.mod h1:ei5JjmxwHaMrgsMrn4U/+Nmg+d8MKS1U2DAn1ou4+Do= github.com/minio/sha256-simd v0.1.1/go.mod h1:B5e1o+1/KgNmWrSQK08Y6Z1Vb5pwIktudl0J58iy0KM= github.com/minio/sha256-simd v1.0.0 h1:v1ta+49hkWZyvaKwrQB8elexRqm6Y0aMLjCNsrYxo6g= github.com/minio/sha256-simd v1.0.0/go.mod h1:OuYzVNI5vcoYIAmbIvHPl3N3jUzVedXbKy5RFepssQM=