fix: 🐛 merge issue comment

close related issue fix #1
bubkoo · Nov 3, 2020 · 7cf29fa · 7cf29fa
1 parent 3e101b9
commit 7cf29fa
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 49 deletions.
diff --git a/packages/a/CHANGELOG.md b/packages/a/CHANGELOG.md
diff --git a/packages/b/CHANGELOG.md b/packages/b/CHANGELOG.md
diff --git a/packages/c/CHANGELOG.md b/packages/c/CHANGELOG.md
diff --git a/packages/d/CHANGELOG.md b/packages/d/CHANGELOG.md
diff --git a/src/plugin.ts b/src/plugin.ts
@@ -107,6 +107,7 @@ export namespace Plugin {
   ) {
     const { cwd } = multiContext
     const { emit, todo, waitFor, waitForAll, getLucky } = synchronizer
+    let successExectued = false
 
     return function create(pkg: Package) {
       const { deps, plugins, dir, path, name } = pkg
@@ -254,39 +255,31 @@ export namespace Plugin {
         return res.length ? res[0] : {}
       }
 
-      let successCount = 0
-      const releases: SemanticRelease.Release[] = []
-
       const success = async (
         pluginOptions: any,
         context: SemanticRelease.Context,
       ) => {
         pkg.published = true
         await waitForAll('published', (p) => p.nextType != null)
-        const packages = todo().filter((p) => p.nextType != null)
-        successCount += 1
-
-        console.log(
-          '=====================================',
-          successCount,
-          '###',
-          packages.length,
-        )
 
-        if (successCount < packages.length) {
-          pluginOptions.successComment = false
-          releases.push(...(context as any).releases)
-        } else {
+        console.log('=====================================', successExectued)
+
+        if (!successExectued) {
+          successExectued = true
+          const packages = todo().filter((p) => p.nextType != null)
+          const releases: SemanticRelease.Release[] = []
+          packages.forEach((p) => {
+            if (p.result) {
+              releases.push(...p.result.releases)
+            }
+          })
           const ctx = context as any
           ctx.releases = releases
           pluginOptions.successComment = getSuccessComment()
           await plugins.success(context)
         }
 
-        // console.log(plugins.success)
-        // const res = await plugins.success(pluginOptions, context)
         debug('succeed: %s', pkg.name)
-        // return res
       }
 
       const plugin: { [key: string]: any } = {