Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve "Websocket error propagation lacks usability" #363

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Add states to websocket clients

7536ef7
Select commit
Loading
Failed to load commit list.
Open

Resolve "Websocket error propagation lacks usability" #363

Add states to websocket clients
7536ef7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 16, 2025 in 0s

86.11% (+0.00%) compared to 2c6194c

View this Pull Request on Codecov

86.11% (+0.00%) compared to 2c6194c

Details

Codecov Report

Attention: Patch coverage is 77.46479% with 16 lines in your changes missing coverage. Please review.

Project coverage is 86.11%. Comparing base (2c6194c) to head (7536ef7).

Files with missing lines Patch % Lines
src/kraken/spot/websocket/connectors.py 70.83% 7 Missing ⚠️
src/kraken/futures/websocket/__init__.py 70.00% 6 Missing ⚠️
src/kraken/spot/websocket/__init__.py 82.35% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #363   +/-   ##
=======================================
  Coverage   86.10%   86.11%           
=======================================
  Files          25       25           
  Lines        2131     2168   +37     
=======================================
+ Hits         1835     1867   +32     
- Misses        296      301    +5     
Files with missing lines Coverage Δ
src/kraken/spot/funding.py 45.83% <ø> (ø)
src/kraken/utils/utils.py 91.30% <100.00%> (+6.68%) ⬆️
src/kraken/spot/websocket/__init__.py 88.88% <82.35%> (-2.03%) ⬇️
src/kraken/futures/websocket/__init__.py 84.61% <70.00%> (+0.22%) ⬆️
src/kraken/spot/websocket/connectors.py 87.15% <70.83%> (+0.09%) ⬆️