Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve "Websocket error propagation lacks usability" #363

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

btschwertfeger
Copy link
Owner

@btschwertfeger btschwertfeger commented Feb 16, 2025

Summary

  • Adding an enum that communicates the websocket connection states
  • Fix typo

Closes #352

Copy link

codecov bot commented Feb 16, 2025

Codecov Report

Attention: Patch coverage is 77.46479% with 16 lines in your changes missing coverage. Please review.

Project coverage is 86.11%. Comparing base (2c6194c) to head (7536ef7).

Files with missing lines Patch % Lines
src/kraken/spot/websocket/connectors.py 70.83% 7 Missing ⚠️
src/kraken/futures/websocket/__init__.py 70.00% 6 Missing ⚠️
src/kraken/spot/websocket/__init__.py 82.35% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #363   +/-   ##
=======================================
  Coverage   86.10%   86.11%           
=======================================
  Files          25       25           
  Lines        2131     2168   +37     
=======================================
+ Hits         1835     1867   +32     
- Misses        296      301    +5     
Flag Coverage Δ
unittests 86.11% <77.46%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/kraken/spot/funding.py 45.83% <ø> (ø)
src/kraken/utils/utils.py 91.30% <100.00%> (+6.68%) ⬆️
src/kraken/spot/websocket/__init__.py 88.88% <82.35%> (-2.03%) ⬇️
src/kraken/futures/websocket/__init__.py 84.61% <70.00%> (+0.22%) ⬆️
src/kraken/spot/websocket/connectors.py 87.15% <70.83%> (+0.09%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Websocket error propagation lacks usability
1 participant