Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Angular 16 support #248

Closed
AmirAlOmari opened this issue May 4, 2023 · 6 comments · Fixed by #251
Closed

Angular 16 support #248

AmirAlOmari opened this issue May 4, 2023 · 6 comments · Fixed by #251
Labels
dependencies Pull requests that update a dependency file

Comments

@AmirAlOmari
Copy link

Since Angular 16 is released, it would be great to bring the support 🙌
@BBlackwo BBlackwo added the dependencies Pull requests that update a dependency file label May 12, 2023
@BBlackwo
Copy link
Collaborator

BBlackwo commented May 12, 2023 •
edited
Loading

Anyone is welcome to raise a PR similar to #237 🙂

Steps

  1. Follow https://update.angular.io/?v=15.0-16.0

  2. Upgrade ngrx/store, ng-packagr, and maybe typescript (or any other libraries that are required)

  3. Upgrade peer dependencies in projects/lib/package.json

  4. Make sure commit message has BREAKING CHANGE in the commit body to do a major bump

@yngvebn yngvebn mentioned this issue May 15, 2023
Merged
13 tasks
@yngvebn
Copy link
Contributor

yngvebn commented May 15, 2023

4. BREAKING CHANGE

Gotcha! I'm pretty sure I did the required steps you outline :)

@sream
Copy link

sream commented May 22, 2023

Any updates regarding the release?

@yngvebn
Copy link
Contributor

yngvebn commented May 23, 2023

Any updates regarding the release?

I'm waiting for @BBlackwo to take a look at my PR. Shouldn't be anything more that's required for this. This is also blocking our upgrade...

@sream
Copy link

sream commented May 23, 2023

I've force installed the current version. It's working but if the changes don't get merged/built until the end of the week I'll just fork your PR and publish it in-house.

@BBlackwo BBlackwo linked a pull request May 24, 2023 that will close this issue
feat: support Angular 16 #251
Merged
13 tasks
@BBlackwo
Copy link
Collaborator

🎉 This issue is fixed in version 16.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support Angular 16 yngvebn/ngrx-store-localstorage
4 participants
@yngvebn @sream @BBlackwo @AmirAlOmari