New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong deserialization for coproducts with empty lists #32

Open

vovapolu opened this issue Mar 12, 2019 · 0 comments

vovapolu commented Mar 12, 2019 •

edited

Loading

import pbdirect._

sealed trait Foo

case class Foo1(li: List[Int])
case class Foo2(ll: List[Long])
import cats.instances.list._

println(Foo1(List.empty).toPB.toSeq)
println(Foo2(List.empty).toPB.toSeq)

// prints
// WrappedArray()
// WrappedArray()

So in general (a: A).toPb.pbTo[A] == a can be false

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment