Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposing params or methods for CSS generation #49

Closed
brumik opened this issue May 21, 2020 · 2 comments · Fixed by #50
Closed

Exposing params or methods for CSS generation #49

brumik opened this issue May 21, 2020 · 2 comments · Fixed by #50
Labels
enhancement New feature or request

Comments

@brumik
Copy link
Owner

brumik commented May 21, 2020

@himdel

I think it could be possible to accept a generateCss function in the params. If it is not supplied the original one would be used and adding a helper method to get the tree depth.

Or/And maybe I could add a function to return the generated CSS as a string, so the parent component could decide where to put it, or if multiple trees are on the page merge them.

What do you think?

@brumik brumik added the enhancement New feature or request label May 21, 2020
@himdel
Copy link
Contributor

himdel commented May 21, 2020

Ooh, that sounds like a great idea.

I think overriding generateCss sounds better if you want to keep wooden tree working (indented) out of the box.

But OTOH I'd also be OK with just documenting what we need to do, so both work.

@brumik
Copy link
Owner Author

brumik commented May 21, 2020

I meant override as well. I add this feature to my todo list.

I can do the css fix then, or you can create a separate PR for it if you have the time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants