Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about iterating LinkedHashMap in Freemarker #168

Closed
pgrt opened this issue Sep 11, 2020 · 2 comments · Fixed by #170
Closed

Question about iterating LinkedHashMap in Freemarker #168

pgrt opened this issue Sep 11, 2020 · 2 comments · Fixed by #170

Comments

@pgrt
Copy link

pgrt commented Sep 11, 2020

Hi,

While packaging version 4.0.0 in Debian, I had to change the iterating on the outputs variable in src/main/resources/org/broadinstitute/barclay/helpTemplates/wdlToolTemplate.wdl.ftl, as two build-time tests were not passing, due to a syntax error in the above-cited file ('>' unexpected at 382, 37, got ',').

I solved the issue with the enclosed patch. You may see if it can be useful for you.

Best,
Pierre
fix_iterating_in_template.txt

@cmnbroad
Copy link
Collaborator

@pgrt Thanks for the patch. The proposed changed seems fine, but I'm unclear why the existing template fails. The freemarker doc seems to indicate that the current syntax is perfectly valid for hashes, and it works for us in both Barclay and GATK. Do you have any insight into why you see this failure but we don't, or why its needed ?

@pgrt
Copy link
Author

pgrt commented Sep 15, 2020

Hi,
Thanks for your reply, I'm happy I could help!
Unfortunately, I am not really able to say why I needed this change. Maybe we have some old software in Debian and your way of iterating is fine for new version? Or the opposite? I don't have enough knowledge about Freemarker.
I see you issued a pull request, I hope it will be fine :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants