You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
An attempt was made to workaround bug #206 downstream by using the suppression feature: bvaughn/react-virtualized#1635
However, that workaround didn't seem to work - the problem still exists with the version deployed afterwards.
I didn't try debugging it, but after a quick code-review I theorize this is caused by additional directives being added before babel-plugin-flow-react-proptypes runs. It might be a different reason, but this stands out.
Obviously a fix for #206 would be more important, but I think the suppression should also be improved.
The text was updated successfully, but these errors were encountered:
ghost
changed the title
Suppression only works for the very first directive (which might not be use-controllable)
Suppression only works for the very first directive (which might not be user-controllable)
Jun 29, 2023
An attempt was made to workaround bug #206 downstream by using the suppression feature: bvaughn/react-virtualized#1635
However, that workaround didn't seem to work - the problem still exists with the version deployed afterwards.
I didn't try debugging it, but after a quick code-review I theorize this is caused by additional directives being added before babel-plugin-flow-react-proptypes runs. It might be a different reason, but this stands out.
The code only checks the first directive:
babel-plugin-flow-react-proptypes/src/index.js
Lines 516 to 522 in 67027b9
I'm not sure why this isn't something like:
Obviously a fix for #206 would be more important, but I think the suppression should also be improved.
The text was updated successfully, but these errors were encountered: