Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use hash to identify policies #39

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Conversation

Bhargavamacha
Copy link
Contributor

@Bhargavamacha Bhargavamacha commented Apr 9, 2024

Summary by CodeRabbit

  • New Features
    • Renamed the project to "rwa-token-sdk" and updated its description for clarity.
    • Enhanced token transfer instructions with additional account validations.
    • Introduced a new policy management system, including creating, attaching, and detaching policies.
    • Added new types and functions to support policy enforcement and account management.
    • Updated program interfaces to improve clarity and consistency across modules.
  • Documentation
    • Improved documentation for data registry, identity registry, and policy engine modules.
  • Bug Fixes
    • Updated error handling and codes for more descriptive feedback on failures.
  • Refactor
    • Overhauled policy engine logic to streamline policy account interactions and enforce policy constraints more effectively.
    • Simplified and clarified function and type names across the SDK to enhance developer understanding and usage.
  • Tests
    • Expanded end-to-end tests to cover new policy features and token transfer logic.
  • Chores
    • Updated dependencies and scripts to align with the project renaming and new functionality.

@Bhargavamacha Bhargavamacha changed the base branch from main to generic_security_fixes April 9, 2024 20:19
Copy link

coderabbitai bot commented Apr 9, 2024

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Walkthrough

The suite of changes centers around a significant overhaul of the rwa-token-sdk, focusing on enhancing policy management, asset control, and identity verification within the system. This includes a project rename, introduction of new functions and types for policy handling, adjustments to account and instruction structures, and refined error management. The updates aim to provide clearer, more flexible mechanisms for attaching, creating, and managing policies across various modules, reflecting a more robust and versatile SDK.

Changes

Files Summary
clients/rwa-token-sdk/package.json, programs/Anchor.toml Project renamed to "rwa-token-sdk"; updated paths and descriptions.
clients/.../src/asset_controller/instructions.ts, clients/.../src/policy_engine/instructions.ts, clients/.../src/policy_engine/utils.ts, clients/.../tests/e2e.test.ts, clients/.../tests/policies.test.ts Added/updated functions for policy and asset control; updated tests.
clients/.../src/policy_engine/types.ts, programs/policy_engine/src/state/account.rs Introduced PolicyType enum; updated policy-related types.
clients/.../src/programs/idls/..., clients/.../src/programs/types/..., programs/.../src/instructions/..., programs/.../src/state/... Updated IDLs, types, and state management for clarity and functionality in policy and identity handling.
programs/.../src/error.rs, clients/.../src/programs/types/asset_controller.ts Refined error handling and error code management.
programs/data_registry/src/instructions/..., programs/identity_registry/src/instructions/..., programs/identity_registry/src/state.rs Adjusted constraints, updated signer verification, and modified state management for data and identity registries.

🐰✨
In the land of code, where changes abound,
A rabbit hopped in, making hardly a sound.
"To improve, to enhance," it whispered with glee,
As it tweaked and it tuned, "Let's make this SDK free!"
With policies aplenty and assets in check,
It danced through the code, a tech-savvy trek.
🌟🚀

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@luke-truitt luke-truitt merged commit a092f80 into generic_security_fixes Apr 10, 2024
luke-truitt pushed a commit that referenced this pull request Apr 10, 2024
* generic security fixes

* use hash to identify policies (#39)

* use hash to identify policies

* use policy account in hash
luke-truitt pushed a commit that referenced this pull request Apr 10, 2024
* update signer checks to use only authority or delegate

* policy hash + patches (#38)

* generic security fixes

* use hash to identify policies (#39)

* use hash to identify policies

* use policy account in hash
luke-truitt pushed a commit that referenced this pull request Apr 17, 2024
… updates (#41)

* make policy account resizable

* resiable idenitty accounts (#35)

* resiable idenitty accounts

* update tests, init more tests

* remove commented files

* update signer checks + hash policy account (#36)

* update signer checks to use only authority or delegate

* policy hash + patches (#38)

* generic security fixes

* use hash to identify policies (#39)

* use hash to identify policies

* use policy account in hash

* Merged resizable policies and dashboards

* Updated clients rwa-token-sdk for resizable policy

* Added program

* update anchor binary

* update idls

* Rename IDL types in client

* use camel case + fix eslint + fix tests partially + update anchor repo

* fix tests

* Added @bridgesplit/sdk update to example

* Updated to support new PolicyType

* Updated policy enum types

* Updated examples

* fix typedoc issues

* fix typedoc issues

* Update instructions

* Updated instructions

* Convention update

* Updated typedoc json

* Updated testing path

* Removed examples

* fix build yaml

* update package + add lint to actions

* update package naming across file

* rm untracked file

* Added conventions

* Updated client to be coral anchor.

* clear github cache

* Deleted old idls

* update file names

* fix tests

---------

Co-authored-by: Bhargava Sai Macha <[email protected]>
Bhargavamacha added a commit that referenced this pull request Apr 17, 2024
… updates (#41) (#42)

* make policy account resizable

* resiable idenitty accounts (#35)

* resiable idenitty accounts

* update tests, init more tests

* remove commented files

* update signer checks + hash policy account (#36)

* update signer checks to use only authority or delegate

* policy hash + patches (#38)

* generic security fixes

* use hash to identify policies (#39)

* use hash to identify policies

* use policy account in hash

* Merged resizable policies and dashboards

* Updated clients rwa-token-sdk for resizable policy

* Added program

* update anchor binary

* update idls

* Rename IDL types in client

* use camel case + fix eslint + fix tests partially + update anchor repo

* fix tests

* Added @bridgesplit/sdk update to example

* Updated to support new PolicyType

* Updated policy enum types

* Updated examples

* fix typedoc issues

* fix typedoc issues

* Update instructions

* Updated instructions

* Convention update

* Updated typedoc json

* Updated testing path

* Removed examples

* fix build yaml

* update package + add lint to actions

* update package naming across file

* rm untracked file

* Added conventions

* Updated client to be coral anchor.

* clear github cache

* Deleted old idls

* update file names

* fix tests

---------

Co-authored-by: Chris Hagedorn <[email protected]>
Co-authored-by: Bhargava Sai Macha <[email protected]>
luke-truitt pushed a commit that referenced this pull request Apr 19, 2024
* Added SDK integration, flexible policy accounts, and general security updates (#41)

* make policy account resizable

* resiable idenitty accounts (#35)

* resiable idenitty accounts

* update tests, init more tests

* remove commented files

* update signer checks + hash policy account (#36)

* update signer checks to use only authority or delegate

* policy hash + patches (#38)

* generic security fixes

* use hash to identify policies (#39)

* use hash to identify policies

* use policy account in hash

* Merged resizable policies and dashboards

* Updated clients rwa-token-sdk for resizable policy

* Added program

* update anchor binary

* update idls

* Rename IDL types in client

* use camel case + fix eslint + fix tests partially + update anchor repo

* fix tests

* Added @bridgesplit/sdk update to example

* Updated to support new PolicyType

* Updated policy enum types

* Updated examples

* fix typedoc issues

* fix typedoc issues

* Update instructions

* Updated instructions

* Convention update

* Updated typedoc json

* Updated testing path

* Removed examples

* fix build yaml

* update package + add lint to actions

* update package naming across file

* rm untracked file

* Added conventions

* Updated client to be coral anchor.

* clear github cache

* Deleted old idls

* update file names

* fix tests

---------

Co-authored-by: Bhargava Sai Macha <[email protected]>

* Fixed documentation (#44)

---------

Co-authored-by: Chris Hagedorn <[email protected]>
luke-truitt added a commit that referenced this pull request Jun 13, 2024
* Staging (#45)

* Added SDK integration, flexible policy accounts, and general security updates (#41)

* make policy account resizable

* resiable idenitty accounts (#35)

* resiable idenitty accounts

* update tests, init more tests

* remove commented files

* update signer checks + hash policy account (#36)

* update signer checks to use only authority or delegate

* policy hash + patches (#38)

* generic security fixes

* use hash to identify policies (#39)

* use hash to identify policies

* use policy account in hash

* Merged resizable policies and dashboards

* Updated clients rwa-token-sdk for resizable policy

* Added program

* update anchor binary

* update idls

* Rename IDL types in client

* use camel case + fix eslint + fix tests partially + update anchor repo

* fix tests

* Added @bridgesplit/sdk update to example

* Updated to support new PolicyType

* Updated policy enum types

* Updated examples

* fix typedoc issues

* fix typedoc issues

* Update instructions

* Updated instructions

* Convention update

* Updated typedoc json

* Updated testing path

* Removed examples

* fix build yaml

* update package + add lint to actions

* update package naming across file

* rm untracked file

* Added conventions

* Updated client to be coral anchor.

* clear github cache

* Deleted old idls

* update file names

* fix tests

---------

Co-authored-by: Bhargava Sai Macha <[email protected]>

* Fixed documentation (#44)

---------

Co-authored-by: Chris Hagedorn <[email protected]>

* Update README.md (#51)

* Remove anchor wallet copy

* lint

---------

Co-authored-by: Bhargava Sai Macha <[email protected]>
Co-authored-by: Luke Truitt <[email protected]>
Bhargavamacha added a commit that referenced this pull request Aug 16, 2024
* Staging (#45)

* Added SDK integration, flexible policy accounts, and general security updates (#41)

* make policy account resizable

* resiable idenitty accounts (#35)

* resiable idenitty accounts

* update tests, init more tests

* remove commented files

* update signer checks + hash policy account (#36)

* update signer checks to use only authority or delegate

* policy hash + patches (#38)

* generic security fixes

* use hash to identify policies (#39)

* use hash to identify policies

* use policy account in hash

* Merged resizable policies and dashboards

* Updated clients rwa-token-sdk for resizable policy

* Added program

* update anchor binary

* update idls

* Rename IDL types in client

* use camel case + fix eslint + fix tests partially + update anchor repo

* fix tests

* Added @bridgesplit/sdk update to example

* Updated to support new PolicyType

* Updated policy enum types

* Updated examples

* fix typedoc issues

* fix typedoc issues

* Update instructions

* Updated instructions

* Convention update

* Updated typedoc json

* Updated testing path

* Removed examples

* fix build yaml

* update package + add lint to actions

* update package naming across file

* rm untracked file

* Added conventions

* Updated client to be coral anchor.

* clear github cache

* Deleted old idls

* update file names

* fix tests

---------

Co-authored-by: Bhargava Sai Macha <[email protected]>

* Fixed documentation (#44)

---------

Co-authored-by: Chris Hagedorn <[email protected]>

* Update README.md (#51)

* Create README.md

---------

Co-authored-by: Bhargava Sai Macha <[email protected]>
Co-authored-by: Luke Truitt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants