Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemengt NoPanicSlice in terms of non-panicing slicing in when it is available in Rust's standard library #138

Closed
briansmith opened this issue Mar 6, 2016 · 5 comments
Closed

Implemengt NoPanicSlice in terms of non-panicing slicing in when it is available in Rust's standard library #138

briansmith opened this issue Mar 6, 2016 · 5 comments
Labels
good-first-bug static-analysis-and-type-safety

Comments

@briansmith
Copy link
Owner

See rust-lang/rfcs#1325.

no_panic::NoPanicSlice::subslice, and maybe other things, should be rewritten when the new Rust functionality is available.
@briansmith
Copy link
Owner Author

It's now rust-lang/rfcs#1679.

@briansmith
Copy link
Owner Author

Now rust-lang/rust#35729

@sfackler
Copy link

sfackler commented Sep 8, 2016

Implementation: rust-lang/rust#36340

@briansmith
Copy link
Owner Author

It's not clear from reading #36340 whether it is possible to use the new feature on Stable rust without the SliceIndex trait being stable.

@briansmith
Copy link
Owner Author

This issue is moot now. First, the code was split out into the untrusted crate, and then we did do this in untrusted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-bug static-analysis-and-type-safety
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@briansmith @sfackler