build: upgrade from ES2018 to ESNext (#52)

* chore: remove unused interval-checking logic

* build: upgrade from ES2018 to ESNext

* style: enforce eslint on config files

* refactor: remove unused luxon helpers

* refactor: rename to assertValid

* style: fix broken eslint rules and enforce them across the codebase

* style: narrow external rule to be exactly what's needed

* style: rename type parameter for better clarity

* feat: also validate date format strings

Author: brianrodri

boundaries.config.js

@@ -8,6 +8,12 @@ export const ELEMENT_SETTINGS = [
     defineFolderScope("model"),
     defineFolderScope("render"),
 
+    {
+        type: "config",
+        pattern: "*.config.js",
+        capture: ["name"],
+        mode: "full",
+    },
     {
         type: "shared",
         pattern: "src/util",
@@ -59,6 +65,10 @@ export const ELEMENT_TYPE_RULES = [
         from: "const",
         allow: ["./*"],
     },
+    {
+        from: [["config", { name: "eslint" }]],
+        allow: [["config", { name: "boundaries" }]],
+    },
 ];
 
 /** @see {@link https://github.com/javierbrea/eslint-plugin-boundaries#rules-configuration} */
@@ -71,6 +81,26 @@ export const EXTERNAL_RULES = [
         from: [["render", { elementName: "preact" }]],
         allow: ["preact", "preact/hooks"],
     },
+    {
+        from: [["config", { name: "eslint" }]],
+        allow: [
+            "@eslint/js",
+            "@vitest/eslint-plugin",
+            "eslint",
+            "eslint/config",
+            "eslint-plugin-boundaries",
+            "eslint-plugin-import",
+            "eslint-plugin-jsdoc",
+            "eslint-plugin-react-hooks",
+            "eslint-plugin-tsdoc",
+            "globals",
+            "typescript-eslint",
+        ],
+    },
+    {
+        from: [["config", { name: "vite" }]],
+        allow: ["@preact/preset-vite", "vite", "vite-plugin-static-copy"],
+    },
     {
         from: "lib",
         allow: ["${from.lib}"],

eslint.config.js

@@ -1,58 +1,41 @@
-import eslintConfigPreact from "eslint-config-preact";
-import eslintConfigPrettier from "eslint-config-prettier";
-import eslintPluginBoundaries from "eslint-plugin-boundaries";
-import eslintPluginImport from "eslint-plugin-import";
+import js from "@eslint/js";
+import vitest from "@vitest/eslint-plugin";
+import { defineConfig } from "eslint/config";
+import boundaries from "eslint-plugin-boundaries";
+import importPlugin from "eslint-plugin-import";
+import jsdoc from "eslint-plugin-jsdoc";
 import eslintPluginReactHooks from "eslint-plugin-react-hooks";
+import tsdoc from "eslint-plugin-tsdoc";
 import globals from "globals";
-import typescriptEslintParser from "@typescript-eslint/parser";
-import typescriptEslintPlugin from "@typescript-eslint/eslint-plugin";
-import eslintPluginJsdoc from "eslint-plugin-jsdoc";
-import eslintPluginTsdoc from "eslint-plugin-tsdoc";
+import typescriptEslint from "typescript-eslint";
+
 import { ELEMENT_SETTINGS, ELEMENT_TYPE_RULES, EXTERNAL_RULES } from "./boundaries.config.js";
-import eslintJs from "@eslint/js";
-import vitestEslintPlugin from "@vitest/eslint-plugin";
 
-/** @type { import("eslint").Linter.Config[] } */
-export default [
+export default defineConfig([
     { ignores: [".husky/", "coverage/", "docs/", "dist/", "node_modules/"] },
 
-    eslintJs.configs.recommended,
-    eslintPluginImport.flatConfigs.recommended,
-    ...eslintConfigPreact.flat,
+    { plugins: { js }, extends: ["js/recommended"] },
+    { plugins: { jsdoc }, files: ["**/*.{js,jsx}"], extends: ["jsdoc/flat/recommended-error"] },
+    { plugins: { jsdoc }, files: ["**/*.{ts,tsx}"], extends: ["jsdoc/flat/recommended-typescript-error"] },
+    { plugins: { tsdoc }, files: ["**/*.{ts,tsx}"], rules: { "tsdoc/syntax": "error" } },
 
     {
-        files: ["*.config.js"],
-        plugins: { jsdoc: eslintPluginJsdoc },
-        languageOptions: { globals: { ...globals.node } },
-        ...eslintPluginJsdoc.configs["flat/recommended-error"],
-        rules: {
-            ...eslintPluginJsdoc.configs["flat/recommended-error"].rules,
-            "import/no-named-as-default": "off",
-            "import/no-unresolved": "off",
-        },
-        settings: {
-            "import/core-modules": ["eslint-config-preact", "eslint-plugin-boundaries", "eslint-plugin-import"],
+        extends: [typescriptEslint.configs.recommendedTypeChecked],
+        files: ["**/*.{ts,tsx}"],
+        languageOptions: {
+            parser: typescriptEslint.parser,
+            parserOptions: { ecmaVersion: "latest", projectService: true, tsconfigRootDir: import.meta.dirname },
         },
     },
 
     {
-        files: ["src/**/*.{ts,tsx}"],
-        ...eslintPluginJsdoc.configs["flat/recommended-typescript-error"],
-        plugins: {
-            "@typescript-eslint": typescriptEslintPlugin,
-            "jsdoc": eslintPluginJsdoc,
-            "react-hooks": eslintPluginReactHooks,
-            "tsdoc": eslintPluginTsdoc,
-        },
-        rules: {
-            ...typescriptEslintPlugin.configs.recommended.rules,
-            ...typescriptEslintPlugin.configs.strict.rules,
-            ...eslintPluginReactHooks.configs.recommended.rules,
-            ...eslintPluginJsdoc.configs["flat/recommended-typescript-error"].rules,
-
-            // https://tsdoc.org/pages/packages/eslint-plugin-tsdoc/
-            "tsdoc/syntax": "error",
+        extends: [eslintPluginReactHooks.configs["recommended-latest"]],
+        files: ["**/*.{ts,tsx}"],
+    },
 
+    {
+        extends: [importPlugin.flatConfigs.recommended],
+        rules: {
             "import/order": [
                 "error",
                 {
@@ -68,38 +51,33 @@ export default [
         },
         settings: {
             "import/core-modules": ["obsidian"],
-        },
-        languageOptions: {
-            globals: { ...globals.browser },
-            parser: typescriptEslintParser,
-            parserOptions: { ecmaFeatures: { modules: true }, ecmaVersion: "latest" },
+            "import/resolver": { typescript: { alwaysTryTypes: true } },
         },
     },
 
     {
-        files: ["src/**/*.test.{ts,tsx}"],
-        ...vitestEslintPlugin.configs.recommended,
-        rules: {
-            "vitest/expect-expect": ["off", { assertFunctionNames: ["expect", "expectTypeOf"] }],
-        },
+        files: ["*.config.js"],
+        languageOptions: { globals: { ...globals.node }, ecmaVersion: "latest", sourceType: "module" },
     },
 
-    // Turns off all rules that are unnecessary or might conflict with Prettier.
-    eslintConfigPrettier,
+    {
+        plugins: { vitest },
+        extends: ["vitest/recommended"],
+        files: ["**/*.test.{ts,tsx}"],
+        rules: { "vitest/expect-expect": ["error", { assertFunctionNames: ["expect", "expectTypeOf"] }] },
+    },
 
     {
-        files: ["src/**/*"],
-        plugins: { boundaries: eslintPluginBoundaries },
+        plugins: { boundaries },
+        extends: ["boundaries/strict"],
         settings: {
-            "boundaries/include": ["src/**/*"],
+            "boundaries/include": ["**/*"],
             "boundaries/ignore": ["**/__tests__/**/*", "**/__mocks__/**/*"],
             "boundaries/elements": ELEMENT_SETTINGS,
-            "import/resolver": { typescript: { alwaysTryTypes: true } },
         },
         rules: {
-            ...eslintPluginBoundaries.configs.strict.rules,
             "boundaries/element-types": ["error", { default: "disallow", rules: ELEMENT_TYPE_RULES }],
             "boundaries/external": ["error", { default: "disallow", rules: EXTERNAL_RULES }],
         },
     },
-];
+]);