Skip to content

Commit 5ce9823

Browse files
authored
docs: remove *.const.ts files from the module index (#41)
* build: bring more consistency to the github workflow definitions * docs: exclude *.const.ts from the documentation index * build: forgive breakages in docs when pushing branches
1 parent 82b104a commit 5ce9823

File tree

6 files changed

+36
-25
lines changed

6 files changed

+36
-25
lines changed

.github/workflows/ci.yml

+10-6
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,33 @@
11
name: CI
22
on:
3-
push:
4-
branches: [main]
5-
pull_request:
6-
branches: [main]
3+
pull_request: { branches: [main] }
4+
push: { branches: [main] }
75

86
jobs:
97
build:
10-
name: ci
8+
name: build:ci
119
runs-on: ubuntu-latest
10+
1211
steps:
1312
- name: Checkout
1413
uses: actions/checkout@v4
14+
1515
- name: Setup Node.js
1616
uses: actions/setup-node@v4
1717
with: { node-version: latest }
18+
1819
- name: Install dependencies
1920
run: npm clean-install
2021
env: { HUSKY: 0 }
21-
- name: Run CI tasks
22+
23+
- name: Build with CI checks
2224
run: npm run build:ci
25+
2326
- name: Upload test results to Codecov
2427
if: ${{ !cancelled() }}
2528
uses: codecov/test-results-action@v1
2629
with: { token: "${{ secrets.CODECOV_TOKEN }}" }
30+
2731
- name: Upload coverage to Codecov
2832
if: ${{ !cancelled() }}
2933
uses: codecov/codecov-action@v5
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
name: Documentation
2-
32
on:
43
push: { branches: [main] }
5-
workflow_dispatch:
64

75
permissions:
86
contents: read
@@ -15,28 +13,34 @@ concurrency:
1513

1614
jobs:
1715
deploy:
18-
name: docs
16+
name: build:docs
17+
runs-on: ubuntu-latest
1918
environment:
2019
name: github-pages
2120
url: ${{ steps.deployment.outputs.page_url }}
22-
runs-on: ubuntu-latest
21+
2322
steps:
2423
- name: Checkout
2524
uses: actions/checkout@v4
26-
- name: Setup Pages
27-
uses: actions/configure-pages@v5
25+
2826
- name: Setup Node.js
2927
uses: actions/setup-node@v4
3028
with: { node-version: latest }
3129

30+
- name: Setup Pages
31+
uses: actions/configure-pages@v5
32+
3233
- name: Install dependencies
3334
run: npm clean-install
3435
env: { HUSKY: 0 }
36+
3537
- name: Build documentation
3638
run: npm run build:docs
39+
3740
- name: Upload artifact
3841
uses: actions/upload-pages-artifact@v3
3942
with: { path: "docs/" }
43+
4044
- name: Deploy to GitHub Pages
4145
id: deployment
4246
uses: actions/deploy-pages@v4

.github/workflows/release.yml

+15-10
Original file line numberDiff line numberDiff line change
@@ -1,30 +1,35 @@
11
name: Release
2-
on: workflow_dispatch
2+
on:
3+
workflow_dispatch:
34

45
permissions:
5-
contents: read # for checkout
6+
contents: read
67

78
jobs:
89
release:
9-
name: Release
10+
name: build:release
1011
runs-on: ubuntu-latest
1112
permissions:
12-
contents: write # to be able to publish a GitHub release
13-
issues: write # to be able to comment on released issues
14-
pull-requests: write # to be able to comment on released pull requests
15-
id-token: write # to enable use of OIDC for npm provenance
13+
contents: write
14+
issues: write
15+
pull-requests: write
16+
id-token: write
17+
1618
steps:
1719
- name: Checkout
18-
uses: actions/checkout@v3
20+
uses: actions/checkout@v4
21+
1922
- name: Setup Node.js
20-
uses: actions/setup-node@v3
23+
uses: actions/setup-node@v4
2124
with: { node-version: latest }
2225

2326
- name: Install dependencies
2427
run: npm clean-install
2528
env: { HUSKY: 0 }
26-
- name: Ensure CI passes
29+
30+
- name: Build with CI checks
2731
run: npm run build:ci
32+
2833
- name: Release update
2934
env: { GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}" }
3035
run: npx semantic-release

.husky/pre-push

-1
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
1-
npm run build:docs
21
npm run test:coverage

src/model/task/util.ts

-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import { DEFAULT_PRIORITY_VALUE, DEFAULT_TYPE_VALUE, Task, TASK_WITH_DEFAULT_VAL
77
/**
88
* @param parts - the task parts to merge.
99
* @returns a new {@link Task} with the front-most non-default values taken from the parts.
10-
* @see {@link TASK_WITH_DEFAULT_VALUES}
1110
*/
1211
export function mergeTaskParts(...parts: DeepPartial<Task>[]): Task {
1312
const defaults = { ...TASK_WITH_DEFAULT_VALUES };

typedoc.config.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ export default {
66
treatValidationWarningsAsErrors: true,
77
plugin: ["typedoc-plugin-coverage", "@typhonjs-typedoc/typedoc-theme-dmt", "typedoc-plugin-dt-links"],
88
theme: "default-modern",
9-
exclude: ["./docs/**/*", "./node_modules/**/*", "**/__tests__/**/*"],
9+
exclude: ["./docs/**/*", "./node_modules/**/*", "**/__tests__/**/*", "**/*.const.ts"],
1010

1111
// https://github.com/typhonjs-typedoc/typedoc-theme-dmt#configuration
1212
dmtNavigation: { style: "flat" },

0 commit comments

Comments
 (0)