Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preferred package for debugging query text? #2484

Closed
jmrlib opened this issue Mar 4, 2021 · 6 comments · Fixed by #2983
Closed

preferred package for debugging query text? #2484

jmrlib opened this issue Mar 4, 2021 · 6 comments · Fixed by #2983
Labels

Comments

@jmrlib
Copy link

jmrlib commented Mar 4, 2021

Hi, I'm wondering if there is a preferred package, extension, or method for providing more detail when you get a syntax error back from the parser (for instance, one that listed line number, column of the error)

for instance, right now:

error: syntax error at or near "as"
    at Parser.parseErrorMessage (/home/collspec/projects/staff-portal/sprint-server/node_modules/pg-protocol/dist/parser.js:278:15)

desired behavior:

error: syntax error at or near "as", line 5, column 7
    at Parser.parseErrorMessage (/home/collspec/projects/staff-portal/sprint-server/node_modules/pg-protocol/dist/parser.js:278:15)
@vitaly-t
Copy link
Contributor

vitaly-t commented Mar 4, 2021

That error is all the server provides, you can't ask for more, if it ain't there.

@sehrope
Copy link
Contributor

sehrope commented Mar 4, 2021

There are a bunch of additional fields on Error objects populated by the driver. If you log the error object you can see them. They correspond to the error fields returned by the server: https://www.postgresql.org/docs/current/protocol-error-fields.html

For example with the command:

SELECT foo
FROM bar

You can get an error like this:

{
  length: 102,
  severity: 'ERROR',
  code: '42P01',
  detail: undefined,
  hint: undefined,
  position: '17',
  internalPosition: undefined,
  internalQuery: undefined,
  where: undefined,
  schema: undefined,
  table: undefined,
  column: undefined,
  dataType: undefined,
  constraint: undefined,
  file: 'parse_relation.c',
  line: '1180',
  routine: 'parserOpenTable'
}

The one you want is position. It gives you the character offset in the SQL of the error. In this example the position value of "17" refers to the start of the bar token in the SQL. It's not always populated though as it depends on what caused the error (generally just parse errors).

@abenhamdine
Copy link
Contributor

abenhamdine commented Apr 25, 2021

For information, since version 8.4.0, you can import DatabaseError interface (see https://github.com/brianc/node-postgres/blob/54b87523e29ea53379d7b9a26e45f83886f371af/CHANGELOG.md#pg840)

the DatabaseError has the following fields :

export class DatabaseError extends Error implements NoticeOrError {

unit tests are there :

offical docs about error properties :
https://www.postgresql.org/docs/13/protocol-error-fields.html

official error codes :
https://www.postgresql.org/docs/current/errcodes-appendix.html

Somebody has already converted these on js constants here :
https://github.com/LinusU/pg-error-constants
but see LinusU/pg-error-constants#1

@abenhamdine
Copy link
Contributor

abenhamdine commented Apr 28, 2021

For anyone interested, I wrote the following typescript enum for error codes.
Be aware that as discussed in LinusU/pg-error-constants#1, 2 error codes can have the same property name because they don't belong to the same error class.

To avoid that, I rename the 2nd property by appending the class shortname
For exemple READING_SQL_DATA_NOT_PERMITTED become READING_SQL_DATA_NOT_PERMITTED_2F for the 2nd occurence.

export const enum PG_ERROR_CODES {
    // Class 00 — Successful Completion,
    SUCCESSFUL_COMPLETION = '00000',
    // Class 01 — Warning,
    WARNING = '01000',
    DYNAMIC_RESULT_SETS_RETURNED = '0100C',
    IMPLICIT_ZERO_BIT_PADDING = '01008',
    NULL_VALUE_ELIMINATED_IN_SET_FUNCTION = '01003',
    PRIVILEGE_NOT_GRANTED = '01007',
    PRIVILEGE_NOT_REVOKED = '01006',
    STRING_DATA_RIGHT_TRUNCATION = '01004',
    DEPRECATED_FEATURE = '01P01',
    // Class 02 — No Data (this is also a warning class per the SQL standard),
    NO_DATA = '02000',
    NO_ADDITIONAL_DYNAMIC_RESULT_SETS_RETURNED = '02001',
    // Class 03 — SQL Statement Not Yet Complete,
    SQL_STATEMENT_NOT_YET_COMPLETE = '03000',
    // Class 08 — Connection Exception,
    CONNECTION_EXCEPTION = '08000',
    CONNECTION_DOES_NOT_EXIST = '08003',
    CONNECTION_FAILURE = '08006',
    SQLCLIENT_UNABLE_TO_ESTABLISH_SQLCONNECTION = '08001',
    SQLSERVER_REJECTED_ESTABLISHMENT_OF_SQLCONNECTION = '08004',
    TRANSACTION_RESOLUTION_UNKNOWN = '08007',
    PROTOCOL_VIOLATION = '08P01',
    // Class 09 — Triggered Action Exception,
    TRIGGERED_ACTION_EXCEPTION = '09000',
    // Class 0A — Feature Not Supported,
    FEATURE_NOT_SUPPORTED = '0A000',
    // Class 0B — Invalid Transaction Initiation,
    INVALID_TRANSACTION_INITIATION = '0B000',
    // Class 0F — Locator Exception,
    LOCATOR_EXCEPTION = '0F000',
    INVALID_LOCATOR_SPECIFICATION = '0F001',
    // Class 0L — Invalid Grantor,
    INVALID_GRANTOR = '0L000',
    INVALID_GRANT_OPERATION = '0LP01',
    // Class 0P — Invalid Role Specification,
    INVALID_ROLE_SPECIFICATION = '0P000',
    // Class 0Z — Diagnostics Exception,
    DIAGNOSTICS_EXCEPTION = '0Z000',
    STACKED_DIAGNOSTICS_ACCESSED_WITHOUT_ACTIVE_HANDLER = '0Z002',
    // Class 20 — Case Not Found,
    CASE_NOT_FOUND = '20000',
    // Class 21 — Cardinality Violation,
    CARDINALITY_VIOLATION = '21000',
    // Class 22 — Data Exception,
    DATA_EXCEPTION = '22000',
    ARRAY_SUBSCRIPT_ERROR = '2202E',
    CHARACTER_NOT_IN_REPERTOIRE = '22021',
    DATETIME_FIELD_OVERFLOW = '22008',
    DIVISION_BY_ZERO = '22012',
    ERROR_IN_ASSIGNMENT = '22005',
    ESCAPE_CHARACTER_CONFLICT = '2200B',
    INDICATOR_OVERFLOW = '22022',
    INTERVAL_FIELD_OVERFLOW = '22015',
    INVALID_ARGUMENT_FOR_LOGARITHM = '2201E',
    INVALID_ARGUMENT_FOR_NTILE_FUNCTION = '22014',
    INVALID_ARGUMENT_FOR_NTH_VALUE_FUNCTION = '22016',
    INVALID_ARGUMENT_FOR_POWER_FUNCTION = '2201F',
    INVALID_ARGUMENT_FOR_WIDTH_BUCKET_FUNCTION = '2201G',
    INVALID_CHARACTER_VALUE_FOR_CAST = '22018',
    INVALID_DATETIME_FORMAT = '22007',
    INVALID_ESCAPE_CHARACTER = '22019',
    INVALID_ESCAPE_OCTET = '2200D',
    INVALID_ESCAPE_SEQUENCE = '22025',
    NONSTANDARD_USE_OF_ESCAPE_CHARACTER = '22P06',
    INVALID_INDICATOR_PARAMETER_VALUE = '22010',
    INVALID_PARAMETER_VALUE = '22023',
    INVALID_REGULAR_EXPRESSION = '2201B',
    INVALID_ROW_COUNT_IN_LIMIT_CLAUSE = '2201W',
    INVALID_ROW_COUNT_IN_RESULT_OFFSET_CLAUSE = '2201X',
    INVALID_TIME_ZONE_DISPLACEMENT_VALUE = '22009',
    INVALID_USE_OF_ESCAPE_CHARACTER = '2200C',
    MOST_SPECIFIC_TYPE_MISMATCH = '2200G',
    NULL_VALUE_NOT_ALLOWED = '22004',
    NULL_VALUE_NO_INDICATOR_PARAMETER = '22002',
    NUMERIC_VALUE_OUT_OF_RANGE = '22003',
    STRING_DATA_LENGTH_MISMATCH = '22026',
    STRING_DATA_RIGHT_TRUNCATION_22 = '22001',
    SUBSTRING_ERROR = '22011',
    TRIM_ERROR = '22027',
    UNTERMINATED_C_STRING = '22024',
    ZERO_LENGTH_CHARACTER_STRING = '2200F',
    FLOATING_POINT_EXCEPTION = '22P01',
    INVALID_TEXT_REPRESENTATION = '22P02',
    INVALID_BINARY_REPRESENTATION = '22P03',
    BAD_COPY_FILE_FORMAT = '22P04',
    UNTRANSLATABLE_CHARACTER = '22P05',
    NOT_AN_XML_DOCUMENT = '2200L',
    INVALID_XML_DOCUMENT = '2200M',
    INVALID_XML_CONTENT = '2200N',
    INVALID_XML_COMMENT = '2200S',
    INVALID_XML_PROCESSING_INSTRUCTION = '2200T',
    // Class 23 — Integrity Constraint Violation,
    INTEGRITY_CONSTRAINT_VIOLATION = '23000',
    RESTRICT_VIOLATION = '23001',
    NOT_NULL_VIOLATION = '23502',
    FOREIGN_KEY_VIOLATION = '23503',
    UNIQUE_VIOLATION = '23505',
    CHECK_VIOLATION = '23514',
    EXCLUSION_VIOLATION = '23P01',
    // Class 24 — Invalid Cursor State,
    INVALID_CURSOR_STATE = '24000',
    // Class 25 — Invalid Transaction State,
    INVALID_TRANSACTION_STATE = '25000',
    ACTIVE_SQL_TRANSACTION = '25001',
    BRANCH_TRANSACTION_ALREADY_ACTIVE = '25002',
    HELD_CURSOR_REQUIRES_SAME_ISOLATION_LEVEL = '25008',
    INAPPROPRIATE_ACCESS_MODE_FOR_BRANCH_TRANSACTION = '25003',
    INAPPROPRIATE_ISOLATION_LEVEL_FOR_BRANCH_TRANSACTION = '25004',
    NO_ACTIVE_SQL_TRANSACTION_FOR_BRANCH_TRANSACTION = '25005',
    READ_ONLY_SQL_TRANSACTION = '25006',
    SCHEMA_AND_DATA_STATEMENT_MIXING_NOT_SUPPORTED = '25007',
    NO_ACTIVE_SQL_TRANSACTION = '25P01',
    IN_FAILED_SQL_TRANSACTION = '25P02',
    // Class 26 — Invalid SQL Statement Name,
    INVALID_SQL_STATEMENT_NAME = '26000',
    // Class 27 — Triggered Data Change Violation,
    TRIGGERED_DATA_CHANGE_VIOLATION = '27000',
    // Class 28 — Invalid Authorization Specification,
    INVALID_AUTHORIZATION_SPECIFICATION = '28000',
    INVALID_PASSWORD = '28P01',
    // Class 2B — Dependent Privilege Descriptors Still Exist,
    DEPENDENT_PRIVILEGE_DESCRIPTORS_STILL_EXIST = '2B000',
    DEPENDENT_OBJECTS_STILL_EXIST = '2BP01',
    // Class 2D — Invalid Transaction Termination,
    INVALID_TRANSACTION_TERMINATION = '2D000',
    // Class 2F — SQL Routine Exception,
    SQL_ROUTINE_EXCEPTION = '2F000',
    FUNCTION_EXECUTED_NO_RETURN_STATEMENT = '2F005',
    MODIFYING_SQL_DATA_NOT_PERMITTED_2F = '2F002',
    PROHIBITED_SQL_STATEMENT_ATTEMPTED_2F = '2F003',
    READING_SQL_DATA_NOT_PERMITTED_2F = '2F004',
    // Class 34 — Invalid Cursor Name,
    INVALID_CURSOR_NAME = '34000',
    // Class 38 — External Routine Exception,
    EXTERNAL_ROUTINE_EXCEPTION = '38000',
    CONTAINING_SQL_NOT_PERMITTED = '38001',
    MODIFYING_SQL_DATA_NOT_PERMITTED = '38002',
    PROHIBITED_SQL_STATEMENT_ATTEMPTED = '38003',
    READING_SQL_DATA_NOT_PERMITTED = '38004',
    // Class 39 — External Routine Invocation Exception,
    EXTERNAL_ROUTINE_INVOCATION_EXCEPTION = '39000',
    INVALID_SQLSTATE_RETURNED = '39001',
    NULL_VALUE_NOT_ALLOWED_39 = '39004',
    TRIGGER_PROTOCOL_VIOLATED = '39P01',
    SRF_PROTOCOL_VIOLATED = '39P02',
    // Class 3B — Savepoint Exception,
    SAVEPOINT_EXCEPTION = '3B000',
    INVALID_SAVEPOINT_SPECIFICATION = '3B001',
    // Class 3D — Invalid Catalog Name,
    INVALID_CATALOG_NAME = '3D000',
    // Class 3F — Invalid Schema Name,
    INVALID_SCHEMA_NAME = '3F000',
    // Class 40 — Transaction Rollback,
    TRANSACTION_ROLLBACK = '40000',
    TRANSACTION_INTEGRITY_CONSTRAINT_VIOLATION = '40002',
    SERIALIZATION_FAILURE = '40001',
    STATEMENT_COMPLETION_UNKNOWN = '40003',
    DEADLOCK_DETECTED = '40P01',
    // Class 42 — Syntax Error or Access Rule Violation,
    SYNTAX_ERROR_OR_ACCESS_RULE_VIOLATION = '42000',
    SYNTAX_ERROR = '42601',
    INSUFFICIENT_PRIVILEGE = '42501',
    CANNOT_COERCE = '42846',
    GROUPING_ERROR = '42803',
    WINDOWING_ERROR = '42P20',
    INVALID_RECURSION = '42P19',
    INVALID_FOREIGN_KEY = '42830',
    INVALID_NAME = '42602',
    NAME_TOO_LONG = '42622',
    RESERVED_NAME = '42939',
    DATATYPE_MISMATCH = '42804',
    INDETERMINATE_DATATYPE = '42P18',
    COLLATION_MISMATCH = '42P21',
    INDETERMINATE_COLLATION = '42P22',
    WRONG_OBJECT_TYPE = '42809',
    UNDEFINED_COLUMN = '42703',
    UNDEFINED_FUNCTION = '42883',
    UNDEFINED_TABLE = '42P01',
    UNDEFINED_PARAMETER = '42P02',
    UNDEFINED_OBJECT = '42704',
    DUPLICATE_COLUMN = '42701',
    DUPLICATE_CURSOR = '42P03',
    DUPLICATE_DATABASE = '42P04',
    DUPLICATE_FUNCTION = '42723',
    DUPLICATE_PREPARED_STATEMENT = '42P05',
    DUPLICATE_SCHEMA = '42P06',
    DUPLICATE_TABLE = '42P07',
    DUPLICATE_ALIAS = '42712',
    DUPLICATE_OBJECT = '42710',
    AMBIGUOUS_COLUMN = '42702',
    AMBIGUOUS_FUNCTION = '42725',
    AMBIGUOUS_PARAMETER = '42P08',
    AMBIGUOUS_ALIAS = '42P09',
    INVALID_COLUMN_REFERENCE = '42P10',
    INVALID_COLUMN_DEFINITION = '42611',
    INVALID_CURSOR_DEFINITION = '42P11',
    INVALID_DATABASE_DEFINITION = '42P12',
    INVALID_FUNCTION_DEFINITION = '42P13',
    INVALID_PREPARED_STATEMENT_DEFINITION = '42P14',
    INVALID_SCHEMA_DEFINITION = '42P15',
    INVALID_TABLE_DEFINITION = '42P16',
    INVALID_OBJECT_DEFINITION = '42P17',
    // Class 44 — WITH CHECK OPTION Violation,
    WITH_CHECK_OPTION_VIOLATION = '44000',
    // Class 53 — Insufficient Resources,
    INSUFFICIENT_RESOURCES = '53000',
    DISK_FULL = '53100',
    OUT_OF_MEMORY = '53200',
    TOO_MANY_CONNECTIONS = '53300',
    CONFIGURATION_LIMIT_EXCEEDED = '53400',
    // Class 54 — Program Limit Exceeded,
    PROGRAM_LIMIT_EXCEEDED = '54000',
    STATEMENT_TOO_COMPLEX = '54001',
    TOO_MANY_COLUMNS = '54011',
    TOO_MANY_ARGUMENTS = '54023',
    // Class 55 — Object Not In Prerequisite State,
    OBJECT_NOT_IN_PREREQUISITE_STATE = '55000',
    OBJECT_IN_USE = '55006',
    CANT_CHANGE_RUNTIME_PARAM = '55P02',
    LOCK_NOT_AVAILABLE = '55P03',
    // Class 57 — Operator Intervention,
    OPERATOR_INTERVENTION = '57000',
    QUERY_CANCELED = '57014',
    ADMIN_SHUTDOWN = '57P01',
    CRASH_SHUTDOWN = '57P02',
    CANNOT_CONNECT_NOW = '57P03',
    DATABASE_DROPPED = '57P04',
    // Class 58 — System Error (errors external to PostgreSQL itself),
    SYSTEM_ERROR = '58000',
    IO_ERROR = '58030',
    UNDEFINED_FILE = '58P01',
    DUPLICATE_FILE = '58P02',
    // Class F0 — Configuration File Error,
    CONFIG_FILE_ERROR = 'F0000',
    LOCK_FILE_EXISTS = 'F0001',
    // Class HV — Foreign Data Wrapper Error (SQL/MED),
    FDW_ERROR = 'HV000',
    FDW_COLUMN_NAME_NOT_FOUND = 'HV005',
    FDW_DYNAMIC_PARAMETER_VALUE_NEEDED = 'HV002',
    FDW_FUNCTION_SEQUENCE_ERROR = 'HV010',
    FDW_INCONSISTENT_DESCRIPTOR_INFORMATION = 'HV021',
    FDW_INVALID_ATTRIBUTE_VALUE = 'HV024',
    FDW_INVALID_COLUMN_NAME = 'HV007',
    FDW_INVALID_COLUMN_NUMBER = 'HV008',
    FDW_INVALID_DATA_TYPE = 'HV004',
    FDW_INVALID_DATA_TYPE_DESCRIPTORS = 'HV006',
    FDW_INVALID_DESCRIPTOR_FIELD_IDENTIFIER = 'HV091',
    FDW_INVALID_HANDLE = 'HV00B',
    FDW_INVALID_OPTION_INDEX = 'HV00C',
    FDW_INVALID_OPTION_NAME = 'HV00D',
    FDW_INVALID_STRING_LENGTH_OR_BUFFER_LENGTH = 'HV090',
    FDW_INVALID_STRING_FORMAT = 'HV00A',
    FDW_INVALID_USE_OF_NULL_POINTER = 'HV009',
    FDW_TOO_MANY_HANDLES = 'HV014',
    FDW_OUT_OF_MEMORY = 'HV001',
    FDW_NO_SCHEMAS = 'HV00P',
    FDW_OPTION_NAME_NOT_FOUND = 'HV00J',
    FDW_REPLY_HANDLE = 'HV00K',
    FDW_SCHEMA_NOT_FOUND = 'HV00Q',
    FDW_TABLE_NOT_FOUND = 'HV00R',
    FDW_UNABLE_TO_CREATE_EXECUTION = 'HV00L',
    FDW_UNABLE_TO_CREATE_REPLY = 'HV00M',
    FDW_UNABLE_TO_ESTABLISH_CONNECTION = 'HV00N',
    // Class P0 — PL/pgSQL Error,
    PLPGSQL_ERROR = 'P0000',
    RAISE_EXCEPTION = 'P0001',
    NO_DATA_FOUND = 'P0002',
    TOO_MANY_ROWS = 'P0003',
    // Class XX — Internal Error,
    INTERNAL_ERROR = 'XX000',
    DATA_CORRUPTED = 'XX001',
    INDEX_CORRUPTED = 'XX002'
}

@CyberCookie
Copy link

error: syntax error at or near "`"
    at Parser.parseErrorMessage (/home/user/some_project/node_modules/pg-protocol/dist/parser.js:287:98)
    at Parser.handlePacket (/home/user/some_project/node_modules/pg-protocol/dist/parser.js:126:29)
    at Parser.parse (/home/user/some_project/node_modules/pg-protocol/dist/parser.js:39:38)
    at Socket.<anonymous> (/home/user/some_project/node_modules/pg-protocol/dist/index.js:11:42)
    at Socket.emit (events.js:400:28)
    at addChunk (internal/streams/readable.js:293:12)
    at readableAddChunk (internal/streams/readable.js:267:9)
    at Socket.Readable.push (internal/streams/readable.js:206:10)
    at TCP.onStreamRead (internal/stream_base_commons.js:188:23) {
  length: 91,
  severity: 'ERROR',
  code: '42601',
  detail: undefined,
  hint: undefined,
  position: '157',
  internalPosition: undefined,
  internalQuery: undefined,
  where: undefined,
  schema: undefined,
  table: undefined,
  column: undefined,
  dataType: undefined,
  constraint: undefined,
  file: 'scan.l',
  line: '1180',
  routine: 'scanner_yyerror'
}

Parsing errors returned from the PG package are almost useless since there is no info about file location where broken query is.

mysql2 package on the other hand do returns file location with broken query

@markcellus
Copy link

Maybe related to #1762

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants