Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOS commands ending in numeric parameter not executed from autoexec.txt #68

Closed
lennart-benschop opened this issue Jun 3, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@lennart-benschop
Copy link

This started to go wrong since v1.04RC1.

autoexec.txt has lines ending in CR-LF. This is normal for text editors under Windows and also Nano on Agon itself.

When a command like "SET KEYBOARD 1" occurs in that file, it is not executed. If I put an additional space after the '1' it works again.

@lennart-benschop
Copy link
Author

These commands work when executed from the MOS command line itself, just not from autoexec.txt

@breakintoprogram
Copy link
Owner

breakintoprogram commented Jun 6, 2023

Please check you have pulled the correct src_fatfs/ffconf.h - FF_USE_STRFUNC should be 1. Dated 13/04/2023. It's working fine on my Agon.

@breakintoprogram breakintoprogram added the bug Something isn't working label Jun 6, 2023
@breakintoprogram breakintoprogram moved this to In Progress in AGON Quark Firmware Jun 6, 2023
@lennart-benschop
Copy link
Author

I checked that I have you current src_fatfs/ffconf.h file with -FFUSE_STRFUNC set to 1.
All file system reads by user programs appear to work correctly, just the strange behaviour with lines in autoexec.txt file.

@lennart-benschop
Copy link
Author

Next weekend I will try to rebuild MOS from a freshly checked out source tree. If you put the command VDU 7 in your autoexec.txt, will you hear the beep? I don't and I did hear it with MOS 1.03/VDP 1.04RC1.

@breakintoprogram
Copy link
Owner

It is quite possible that this is a bug - I've improved error checking on parameters and I can see why that may fail.

@breakintoprogram breakintoprogram moved this from In Progress to QA in AGON Quark Firmware Jun 30, 2023
@breakintoprogram breakintoprogram moved this from QA to In Progress in AGON Quark Firmware Jun 30, 2023
@breakintoprogram breakintoprogram moved this from In Progress to QA in AGON Quark Firmware Jul 8, 2023
@breakintoprogram breakintoprogram moved this from QA to Done in AGON Quark Firmware Jul 8, 2023
@breakintoprogram
Copy link
Owner

The MOS now trims whitespace from any command executed by mos_exec.

@breakintoprogram breakintoprogram moved this from Done to Released in AGON Quark Firmware Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Released
Development

No branches or pull requests

2 participants