SyntaxError: Unexpected token: name (WebTorrentRemoteClient)

[luixxiul]

Describe the issue you encountered:

By running a build script the following error happens and the packaged build does not start.

ERROR in webtorrentPage.entry.js from UglifyJs
SyntaxError: Unexpected token: name (WebTorrentRemoteClient) [./~/webtorrent-remote/client.js:10,0]

From Terminal when I try to open the program, I get this.

Brave-MacBook-Pro:browser-laptop Suguru$ open ./Brave-darwin-x64/Brave.app
LSOpenURLsWithRole() failed with error -10810 for the file /Users/Suguru/browser-laptop/Brave-darwin-x64/Brave.app.

• Platform (Win7, 8, 10? macOS? Linux distro?): macOS

• Brave Version: master branch

• Any related issues:

[luixxiul]

ccing @feross @dcposch for thought.

[dcposch]

Just to confirm, you ran npm install first, right?

Do you see a webtorrent-remote folder under node_modules?

[luixxiul]

@dcposch yes I did and I see the folder. @bsclifton has noticed the error too if I remember correctly.

[luixxiul]

FYI the issue does not happen if I run the browser via npm run watch and npm start. For me it happens on the packaged build only.

[dcposch]

Yes, I see it too now.

$ CHANNEL=dev npm run build-package
...
ERROR in webtorrentPage.entry.js from UglifyJs
    SyntaxError: Unexpected token: name (WebTorrentRemoteClient) [./~/webtorrent-remote/client.js:10,0]

Sorry about that! Trying to fix it now.

[dcposch]

Narrowed it down a bit:

Works

CHANNEL=dev ./node_modules/.bin/webpack

Doesn't work

NODE_ENV=production CHANNEL=dev ./node_modules/.bin/webpack

...& that's what the packager script does.

[dcposch]

OK, here's what might be happening:

• When NODE_ENV=production, we use Uglify
• Uglify doesn't like the ES6 features, specifically class, that we're using in webtorrent-remote

[dcposch]

I'm changing webtorrent-remote to not use class. Almost done

[dcposch]

I removed all ES6 from webtorrent-remote and the build is working for me now. See #5847

[luixxiul]

That error disappears for me too, but LSOpenURLsWithRole() failed with error -10810 still happens. Maybe another thing is related here, cc: @bbondy

I opened another issue for that: #5849

[luixxiul]

I added release-notes/exclude as the bug appeared and was fixed within the same milestone.