Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Magnifying glass icon shown for pdf documents opened in Brave #5774

Closed
srirambv opened this issue Nov 21, 2016 · 1 comment
Closed

Magnifying glass icon shown for pdf documents opened in Brave #5774

srirambv opened this issue Nov 21, 2016 · 1 comment

Comments

@srirambv
Copy link
Collaborator

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Magnifying glass icon shown for pdf documents opened in Brave

Expected behavior:
Should show the padlock symbol based on the connection type(secure/insecure) or use fa-file-pdf-o icon for pdf documents

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All

  • Brave Version:
    0.12.10 RC1

  • Steps to reproduce:

    1. Open http://www.orimi.com/pdf-test.pdf
    2. Shows magnifying glass icon
    3. Clicking on that shows the connection state(secure/insecure)
  • Screenshot if needed:
    screenshot from 2016-11-21 16-47-55

  • Any related issues:
    Please change the milestone if needed

@diracdeltas
Copy link
Member

I think PDFs should just show up as whatever the embedded document protocol is. AKA unlocked icon for HTTP PDFs, locked icon for HTTPS. Right now there it always displays as insecure:
screen shot 2016-11-21 at 10 08 18 am

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants