Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

register button for ledger should remain enabled after denying handler registration #5197

Closed
luixxiul opened this issue Oct 27, 2016 · 1 comment

Comments

@luixxiul
Copy link
Contributor

Describe the issue you encountered: the register button for ledger should remain enabled after denying handler registration. For now you have to click "unregister" button to re-enable the register button

  • Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10
  • Brave Version: 0.12.7 RC1
  • Steps to reproduce:
    1. Open https://jsfiddle.net/LnwtLckc/5/
    2. Click "register" and "deny" on the notification bar
    3. Click "register" again -> notification bar is not displayed
    4. Click "unregister" and "register" again -> the bar is displayed
  • Any related issues:
@mrose17 mrose17 added this to the 0.12.11 milestone Nov 8, 2016
@mrose17 mrose17 removed this from the 0.12.11 milestone Nov 17, 2016
@mrose17
Copy link
Member

mrose17 commented Nov 17, 2016

@luixxiul - thanks! this is a very interesting issue

@bbondy - this is a generic problem with the protocol handler registration.

if you click the "register" button (in the lower-right quadrant) and then click "Deny" in the notification bar at the top, then clicking the "register" button again appears to be a no-op; however, if you click the "unregister" button, then clicking on the "register" button will cause the notification bar to appear as it should.

the ledger client code in the browser doesn't control any of this...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants