Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

display dark grey verified icon for verified publishers #3467

Closed
diracdeltas opened this issue Aug 27, 2016 · 17 comments
Closed

display dark grey verified icon for verified publishers #3467

diracdeltas opened this issue Aug 27, 2016 · 17 comments
Assignees
Labels
design A design change, especially one which needs input from the design team. feature/rewards QA/checked-macOS
Milestone

Comments

@diracdeltas
Copy link
Member

now that #3198 is implemented. we don't currently have any verified publishers (that i know of), but we can set brave.com as verified for testing purposes.

@mrose17
Copy link
Member

mrose17 commented Aug 27, 2016

@diracdeltas - perhaps this issue should be closed and moved over to the ledger repo...

we can test the code in the browser, but not until the ledger actually reports the verification status...

@diracdeltas
Copy link
Member Author

@mrose17 #3198 is the issue for the ledger to report verification status, i thought. this is just the front-end issue.

@bsclifton
Copy link
Member

Like @diracdeltas said, I think this could be used just to track adding a CSS class to a verified publisher (if the backend provides info that it's verified). 😄 Maybe the backend could be stubbed to always return verified for brave.com until the code is implemented

@bsclifton
Copy link
Member

Also curious what this would look like- would it be like a Twitter verified icon? 😄

cc: @bradleyrichter

@bsclifton bsclifton added the design A design change, especially one which needs input from the design team. label Aug 27, 2016
@diracdeltas diracdeltas added this to the 1.0.0 milestone Aug 27, 2016
@bradleyrichter
Copy link
Contributor

Changing it to a thumbs up to avoid confusion with shields.

image

@bradleyrichter bradleyrichter changed the title display green verified icon for verified publishers display dark grey verified icon for verified publishers Sep 8, 2016
@bradleyrichter
Copy link
Contributor

image

@bbondy
Copy link
Member

bbondy commented Sep 8, 2016

Could we use some kind of a verified badge kind of like twitter? Something that people are already familiar with, to me thumbs up doesn't scream verified. I think checkmark at least. Thumbs up means more "I like this" to the world of facebook users.

@bsclifton
Copy link
Member

Agree w/ @bbondy (note that I also thumbs uped his post 😜 )

@bradleyrichter
Copy link
Contributor

Better?

image

I don't want to use a shield which feels wrong.

I don't want use a checkmark as it may be confused with a UI button element.

@bbondy
Copy link
Member

bbondy commented Sep 11, 2016

that's better yep

@bradleyrichter
Copy link
Contributor

I would like to add a white checkmark to the center of this "certificate" icon.

(when we get to it)

( @jkup has a recipe already)

@jkup jkup self-assigned this Sep 15, 2016
@jkup
Copy link
Contributor

jkup commented Sep 15, 2016

Yep I've done one already for bitcoin.. I'll tackle this ticket if that's cool with everyone

@diracdeltas
Copy link
Member Author

@jkup sgtm. since no publishers are verified currently, i think we should mock-verify brave.com for now

@jkup
Copy link
Contributor

jkup commented Sep 15, 2016

@diracdeltas sgtm how can we mock-verify brave? Can @mrose17 do it manually?

@diracdeltas
Copy link
Member Author

yeah it would be better for ledger back-end to report it as verified; if that is too much work for some reason, you can just set it in the front-end

@bradleyrichter
Copy link
Contributor

we can mock-verify brianbondy.com too.

@mrose17 mrose17 modified the milestones: 0.12.7dev, 1.0.0 Oct 22, 2016
@mrose17
Copy link
Member

mrose17 commented Oct 22, 2016

now that ad98442 is committed to master, who will volunteer to fix the browser CSS...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. feature/rewards QA/checked-macOS
Projects
None yet
Development

No branches or pull requests

7 participants