Clear browser history should work regardless of whether or not the page is bookmarked.

[alexwykoff]

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
When attempting to clear browser history, I noticed that certain pages were staying in history. When I deleted the bookmark and cleared the history again, the history line item for that formerly bookmarked page disappeared.

Expected behavior:
All browser history should be cleared regardless of bookmark status.

• Platform (Win7, 8, 10? macOS? Linux distro?):
  Tested on OS X
• Brave Version:
  0.11.6 pre-beta2
• Steps to reproduce:
  1. Visit and bookmark some sites.
  2. Go to about:history and clear history, notice remaining items.
  3. Delete a bookmark and clear history.
• Screenshot if needed:
  
• Any related issues:

[alexwykoff]

Sorry, dup of #3330. My issue searching regex-fu wasn't strong enough.

[bridiver]

I don't think #3330 is the same thing. The real issue appears to be the inclusion of non-history items in the history

history={frame.get('location') === 'about:history'
                ? this.props.appState.get('sites') || emptyMap
                : null}

cc @bbondy

[bsclifton]

Definitely not the same thing- the entire sites list is being sent over, which contains bookmarks and history. That could be optimized and additionally (to fix the issue), about:history needs to hide entries which have a null timestamp

[bsclifton]

Submitted PR w/ fix 😄
#3501

opened a new ticket for the refactoring concerns
#3502

[bsclifton]

To verify the fix

• Install a version of Brave which has the fix
• Launch Brave and navigate to about:history
• Launch a new tab, visiting a page which has not been visited yet
• Bookmark this previously unvisited site
• Return to history tab
• Verify the site you just visited shows up
• Click the Clear browsing history button
• Make sure to pick Browser history and click OK
• Verify that the bookmarked site no longer shows up