deleting database broken on fmphost.com

[diracdeltas]

bug reporter at support@brave says this works in chrome but not in brave.

The button in the service triggers a javascript function — I guess one that is defined locally: "deleteDatabase" with 2 parameters, something that looks like the service's ID for the database, and the server address.

I don't have an fmphost account to test this out; if anyone does, please copy any console errors.

[diracdeltas]

Appears that the problem is that deleteDatabase calls window.confirm, which apparently does nothing sometimes in Brave. I can't repro the conditions that cause it to not work.

[diracdeltas]

got it to happen by:

1. cleaned session store. verified that going to fmphost.com and calling window.confirm worked as expected.
2. logged into fmphost and was redirected to https://my.fmphost.com/clientarea.php. window.confirm no longer works; console says window.confirm is function confirm() { [native code] }.
3. reloaded the page. now console says window.confirm is function (message, title) { return ipc.sendSync('window-confirm', message, title); } as expected.

cc @bridiver @bbondy

[diracdeltas]

actually it just looks like window.confirm isn't being set correctly after navigation. ex: go to bing.com, click on any link to navigate, and window.confirm is broken.

[bridiver]

I think a change in chromium 50 broke this. The window functions won't be reloaded if a new render frame is not created

[bridiver]

fixed brave/muon@22312fc

[BrendanEich]

Any way to add a regression test for this? Thanks.

[diracdeltas]

sure i'll add a test for this