Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

recovery tab for a download will relaunch #1431

Closed
bojake opened this issue Apr 21, 2016 · 6 comments
Closed

recovery tab for a download will relaunch #1431

bojake opened this issue Apr 21, 2016 · 6 comments
Labels
duplicate Issue has already been reported
Milestone

Comments

@bojake
Copy link

bojake commented Apr 21, 2016

If you end your brave session after a successful zip file download and then restart you will see the recovery tab for the zip file download reappear and prompt you to download it again.

brave should not preserve download links that are tabbed.

@bradleyrichter bradleyrichter added this to the 0.9.4dev milestone Apr 26, 2016
@bradleyrichter
Copy link
Contributor

@bbondy We should get this in soon. I just hit cancel 5 times after a restart due to empty tabs respawning downloads.

@bojake
Copy link
Author

bojake commented Apr 26, 2016

imagine what a malicious script might be able to do with this fun gem.

@bbondy
Copy link
Member

bbondy commented Apr 27, 2016

@bojake If you navigate to a script it'll load the script as text, it is not run. Also even if it was, which it isn't, if you run a malicious script once or multiple times it's still bad. Please clarify in more detail what you mean.

@bojake
Copy link
Author

bojake commented Apr 27, 2016

Imagine if I am able to write to the save file used by Brave to "know" what tabs to reopen. So I just flood that save file with more tabs that download stuff. Effectively I am able to ddos on the brave browser. All I need is local file access.

@bbondy
Copy link
Member

bbondy commented Apr 27, 2016

I don't think I understand the security threat.

@bbondy bbondy modified the milestones: 0.10.1dev, 0.10.0dev May 8, 2016
@bbondy
Copy link
Member

bbondy commented May 15, 2016

This will be fixed here #1219. Duping to that.

@bbondy bbondy closed this as completed May 15, 2016
@luixxiul luixxiul added the duplicate Issue has already been reported label Sep 29, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
duplicate Issue has already been reported
Projects
None yet
Development

No branches or pull requests

4 participants