Cannot set property 'enabled' of null when launching or closing Brave.

[srirambv]

Test plan

1. Launch Brave from CLI
2. Verify no errors are shown in stdout
3. Verify menu works as expected (share items are named as expected

Description

Cannot set property 'enabled' of null when launching from brave

Steps to Reproduce

1. Build from 9306021
2. Launch from console
3. Throws error when browser is launched

Actual result:

$ npm run start

> [email protected] start C:\work\browser-laptop
> node ./tools/start.js --user-data-dir-name=brave-development --enable-logging --v=0 --enable-extension-activity-logging --enable-sandbox-logging --enable-dcheck

Crash reporting enabled
An uncaught exception occurred in the main process Uncaught Exception:
TypeError: Cannot set property 'enabled' of null
    at setMenuItemAttribute (C:\work\browser-laptop\app\browser\menu.js:647:23)
    at updateShareMenuItems (C:\work\browser-laptop\app\browser\menu.js:664:5)
    at doAction (C:\work\browser-laptop\app\browser\menu.js:690:11)
    at reducers.reduce (C:\work\browser-laptop\js\stores\appStore.js:188:24)
    at Array.reduce (<anonymous>)
    at applyReducers (C:\work\browser-laptop\js\stores\appStore.js:186:68)
    at handleAppAction (C:\work\browser-laptop\js\stores\appStore.js:253:16)
    at callbacks.forEach (C:\work\browser-laptop\js\dispatcher\appDispatcher.js:107:7)
    at Array.forEach (<anonymous>)
    at AppDispatcher.dispatchToOwnRegisteredCallbacks (C:\work\browser-laptop\js\dispatcher\appDispatcher.js:106:20)

Expected result:
Shouldn't show the error

Reproduces how often:
100%

Brave Version

about:brave info:
0.22.700 9306021

• libchromiumcontent 66.0.3359.139
• muon: 6.0.7

Reproducible on current live release:
No

Additional Information

Reproduced on macOS by @LaurenWags

[kjozwiak]

This is also happening when launching 0.22.701 339ffd6 which is the latest beta build. You'll get the above silent crash in the terminal which is also being logged under chrome://crashes.

• macOS 10.13.3 x64 - Reproduced
• Win 10 x64 - Reproduced
• Mint 18.3 x64 - Reproduced

[bsclifton]

Likely caused by #13933 - I did have to do a manual merge for 0.22.x-release3

[kjozwiak]

You'll get the above silent crash when you close Brave as well. Those crashes are also being logged within chrome://crashes.

[bsclifton]

Fixed with 1b312a2

[GeetaSarvadnya]

Verified on Windows x64

• 0.22.702 e4a853d
• libchromiumcontent 66.0.3359.139
• muon: 6.0.7

Verified with macOS 10.12.6 using

• 0.22.702 e4a853d
• muon 6.0.7
• libchromiumcontent 66.0.3359.139

Verified on Mint 18.3 x64 using the following build:

• 0.22.702 e4a853d
• Muon: 6.0.7
• libchromiumcontent: 66.0.3359.139

Verified on Ubuntu 17.10 x64 using the following build:

• 0.22.702 e4a853d
• Muon: 6.0.7
• libchromiumcontent: 66.0.3359.139