From 9738f4178c46a0f1bc4fe5ebe136fe802b7182e4 Mon Sep 17 00:00:00 2001
From: NejcZdovc <nejc.zdovc@3zsistemi.si>
Date: Fri, 16 Jun 2017 16:51:35 +0200
Subject: [PATCH] Converts NotificationBar and NotificationItem into redux
 components

Resolves #9451

Auditors: @bsclifton @bridiver

Test Plan:
---
 app/renderer/components/main/main.js          | 11 ++-
 .../components/main/notificationBar.js        | 42 ++++++----
 .../components/main/notificationItem.js       | 82 +++++++++++++------
 3 files changed, 87 insertions(+), 48 deletions(-)

diff --git a/app/renderer/components/main/main.js b/app/renderer/components/main/main.js
index 22a8540d79d..4f6dcd26155 100644
--- a/app/renderer/components/main/main.js
+++ b/app/renderer/components/main/main.js
@@ -679,12 +679,12 @@ class Main extends ImmutableComponent {
     const customTitlebar = this.customTitlebar
     const contextMenuDetail = this.props.windowState.get('contextMenuDetail')
     const shouldAllowWindowDrag = windowState.shouldAllowWindowDrag(this.props.appState, this.props.windowState, activeFrame, isFocused())
+    const activeOrigin = activeFrame ? siteUtil.getOrigin(activeFrame.get('location')) : null
+    const notificationBarIsVisible = activeOrigin && this.props.appState.get('notifications').filter((item) =>
+      item.get('frameOrigin') ? activeOrigin === item.get('frameOrigin') : true).size > 0
 
     const appStateSites = this.props.appState.get('sites')
 
-    const notifications = this.props.appState.get('notifications')
-    const hasNotifications = notifications && notifications.size
-
     return <div id='window'
       className={cx({
         isFullScreen: activeFrame && activeFrame.get('isFullScreen'),
@@ -824,11 +824,10 @@ class Main extends ImmutableComponent {
         </div>
         <TabsToolbar key='tab-bar' />
         {
-          hasNotifications && activeFrame
-          ? <NotificationBar notifications={notifications} activeFrame={activeFrame} />
+          notificationBarIsVisible
+          ? <NotificationBar />
           : null
         }
-
         {
           activeFrame && activeFrame.get('findbarShown') && !activeFrame.get('isFullScreen')
           ? <FindBar
diff --git a/app/renderer/components/main/notificationBar.js b/app/renderer/components/main/notificationBar.js
index d42784c47b8..6df1b2aeca0 100644
--- a/app/renderer/components/main/notificationBar.js
+++ b/app/renderer/components/main/notificationBar.js
@@ -4,42 +4,52 @@
 
 const React = require('react')
 const {StyleSheet, css} = require('aphrodite/no-important')
+const Immutable = require('immutable')
 
 // Components
-const ImmutableComponent = require('../immutableComponent')
+const ReduxComponent = require('../reduxComponent')
 const NotificationItem = require('./notificationItem')
 
 // Utils
 const {getOrigin} = require('../../../../js/state/siteUtil')
+const frameStateUtil = require('../../../../js/state/frameStateUtil')
 
 // Styles
 const commonStyles = require('../styles/commonStyles')
 const globalStyles = require('../styles/global')
 
-class NotificationBar extends ImmutableComponent {
-  render () {
-    const activeOrigin = getOrigin(this.props.activeFrame.get('location'))
-    if (!activeOrigin) {
-      return null
-    }
-    const activeNotifications = this.props.notifications.filter((item) =>
-      item.get('frameOrigin') ? activeOrigin === item.get('frameOrigin') : true)
+class NotificationBar extends React.Component {
+  mergeProps (state, ownProps) {
+    const currentWindow = state.get('currentWindow')
+    const activeFrame = frameStateUtil.getActiveFrame(currentWindow) || Immutable.Map()
+    const activeOrigin = getOrigin(activeFrame.get('location'))
+    const notifications = state.get('notifications')
 
-    if (!activeNotifications.size) {
-      return null
-    }
+    const props = {}
+    props.activeNotifications = notifications
+      .filter((item) => {
+        return item.get('frameOrigin')
+          ? activeOrigin === item.get('frameOrigin')
+          : true
+      })
+      .takeLast(3)
+      .map((notification) => notification.get('message'))
 
+    return props
+  }
+
+  render () {
     return <div className={css(commonStyles.notificationBar)} data-test-id='notificationBar'>
       {
-        activeNotifications.takeLast(3).map((notificationDetail) =>
-          <NotificationItem detail={notificationDetail} />
+        this.props.activeNotifications.map((message) =>
+          <NotificationItem message={message} />
         )
       }
     </div>
   }
 }
 
-class NotificationBarCaret extends ImmutableComponent {
+class NotificationBarCaret extends React.Component {
   render () {
     return <div className={css(styles.caretWrapper)}>
       <div className={css(styles.caretWrapper__caret)} />
@@ -75,6 +85,6 @@ const styles = StyleSheet.create({
 })
 
 module.exports = {
-  NotificationBar,
+  NotificationBar: ReduxComponent.connect(NotificationBar),
   NotificationBarCaret
 }
diff --git a/app/renderer/components/main/notificationItem.js b/app/renderer/components/main/notificationItem.js
index 89286d948a0..3ba54190f8b 100644
--- a/app/renderer/components/main/notificationItem.js
+++ b/app/renderer/components/main/notificationItem.js
@@ -3,11 +3,12 @@
  * You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 const React = require('react')
+const Immutable = require('immutable')
 const ipc = require('electron').ipcRenderer
 const {StyleSheet, css} = require('aphrodite/no-important')
 
 // Components
-const ImmutableComponent = require('../immutableComponent')
+const ReduxComponent = require('../reduxComponent')
 const BrowserButton = require('../common/browserButton')
 
 // Constants
@@ -22,22 +23,35 @@ const cx = require('../../../../js/lib/classSet')
 // Styles
 const commonStyles = require('../styles/commonStyles')
 
-class NotificationItem extends ImmutableComponent {
-  clickHandler (buttonIndex, e) {
-    const nonce = this.props.detail.get('options').get('nonce')
-    if (nonce) {
-      ipc.emit(messages.NOTIFICATION_RESPONSE + nonce, {},
-               this.props.detail.get('message'),
-               buttonIndex, this.checkbox ? this.checkbox.checked : false)
+class NotificationItem extends React.Component {
+  constructor (props) {
+    super(props)
+    this.openAdvanced = this.openAdvanced.bind(this)
+    this.toggleCheckbox = this.toggleCheckbox.bind(this)
+  }
+
+  clickHandler (buttonIndex) {
+    if (this.props.nonce) {
+      ipc.emit(
+        messages.NOTIFICATION_RESPONSE + this.props.nonce,
+        {},
+        this.props.message,
+        buttonIndex,
+        this.checkbox ? this.checkbox.checked : false
+      )
     } else {
-      ipc.send(messages.NOTIFICATION_RESPONSE, this.props.detail.get('message'),
-               buttonIndex, this.checkbox ? this.checkbox.checked : false)
+      ipc.send(
+        messages.NOTIFICATION_RESPONSE,
+        this.props.message,
+        buttonIndex,
+        this.checkbox ? this.checkbox.checked : false
+      )
     }
   }
 
   openAdvanced () {
     appActions.createTabRequested({
-      url: this.props.detail.get('options').get('advancedLink')
+      url: this.props.advancedLink
     })
   }
 
@@ -45,47 +59,63 @@ class NotificationItem extends ImmutableComponent {
     this.checkbox.checked = !this.checkbox.checked
   }
 
+  mergeProps (state, ownProps) {
+    const notification = state.get('notifications')
+        .find((notification) => {
+          return notification.get('message') === ownProps.message
+        }) || Immutable.Map()
+
+    const props = {}
+    props.message = ownProps.message
+    props.greeting = notification.get('greeting')
+    props.buttons = notification.get('buttons') // TODO (nejc) only primitives
+    props.style = notification.getIn(['options', 'style'])
+    props.advancedText = notification.getIn(['options', 'advancedText'])
+    props.advancedLink = notification.getIn(['options', 'advancedLink'])
+    props.persist = notification.getIn(['options', 'persist'])
+    props.nonce = notification.getIn(['options', 'nonce'])
+
+    return props
+  }
+
   render () {
-    let i = 0
-    const options = this.props.detail.get('options')
-    const greeting = this.props.detail.get('greeting')
     return <div className={cx({
       notificationItem: true,
       [css(commonStyles.notificationBar__notificationItem)]: true,
-      [options.get('style')]: options.get('style')
+      [this.props.style]: this.props.style
     })}>
       <div className={css(styles.flexJustifyBetween, styles.flexAlignCenter)}>
         <div className={css(styles.marginRight)}>
           {
-            greeting
-              ? <span className={css(commonStyles.notificationItem__greeting)} data-test-id='greeting'>{greeting}</span>
+            this.props.greeting
+              ? <span className={css(commonStyles.notificationItem__greeting)} data-test-id='greeting'>{this.props.greeting}</span>
               : null
           }
-          <span className={css(commonStyles.notificationItem__message)}>{this.props.detail.get('message')}</span>
+          <span className={css(commonStyles.notificationItem__message)}>{this.props.message}</span>
           <span className={css(styles.advanced)}>
             {
-              options.get('advancedText') && options.get('advancedLink')
-                ? <span onClick={this.openAdvanced.bind(this)}>{options.get('advancedText')}</span>
+              this.props.advancedText && this.props.advancedLink
+                ? <span onClick={this.openAdvanced}>{this.props.advancedText}</span>
                 : null
             }
           </span>
         </div>
         <span className={css(styles.flexAlignCenter)} data-test-id='notificationOptions'>
           {
-            options.get('persist')
+            this.props.persist
               ? <span id='rememberOption'>
                 <input className={css(styles.checkbox)} type='checkbox' ref={(node) => { this.checkbox = node }} />
-                <label className={css(styles.label)} htmlFor='rememberOption' data-l10n-id='rememberDecision' onClick={this.toggleCheckbox.bind(this)} />
+                <label className={css(styles.label)} htmlFor='rememberOption' data-l10n-id='rememberDecision' onClick={this.toggleCheckbox} />
               </span>
               : null
           }
           {
-            this.props.detail.get('buttons').map((button) =>
+            this.props.buttons.map((button, i) =>
               <BrowserButton groupedItem secondaryColor notificationItem
                 iconClass={button.get('className')}
                 testId='notificationButton'
                 label={button.get('text')}
-                onClick={this.clickHandler.bind(this, i++)}
+                onClick={this.clickHandler.bind(this, i)}
               />
             )
           }
@@ -95,6 +125,8 @@ class NotificationItem extends ImmutableComponent {
   }
 }
 
+module.exports = ReduxComponent.connect(NotificationItem)
+
 const styles = StyleSheet.create({
   flexJustifyBetween: {
     display: 'flex',
@@ -124,5 +156,3 @@ const styles = StyleSheet.create({
     margin: '5px'
   }
 })
-
-module.exports = NotificationItem