From 6e9931e51d32db2f1751e898c04df19d587ca578 Mon Sep 17 00:00:00 2001 From: Pranjal Jumde Date: Fri, 22 Mar 2019 11:42:12 -0700 Subject: [PATCH] Adding unittest for disabled metrics reporting --- .../enabled_state_provider_unittest.cc | 27 +++++++++++++++++++ test/BUILD.gn | 1 + 2 files changed, 28 insertions(+) create mode 100644 chromium_src/components/metrics/enabled_state_provider_unittest.cc diff --git a/chromium_src/components/metrics/enabled_state_provider_unittest.cc b/chromium_src/components/metrics/enabled_state_provider_unittest.cc new file mode 100644 index 000000000000..9b4c26244d33 --- /dev/null +++ b/chromium_src/components/metrics/enabled_state_provider_unittest.cc @@ -0,0 +1,27 @@ +/* Copyright (c) 2019 The Brave Authors. All rights reserved. + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this file, + * You can obtain one at http://mozilla.org/MPL/2.0/. */ + +#include "chrome/browser/metrics/chrome_metrics_services_manager_client.h" + +#include "chrome/browser/metrics/chrome_metrics_service_accessor.h" +#include "components/metrics/enabled_state_provider.h" +#include "components/metrics/metrics_pref_names.h" +#include "components/prefs/pref_registry_simple.h" +#include "components/prefs/testing_pref_service.h" +#include "testing/gtest/include/gtest/gtest.h" + +TEST(ChromeMetricsServicesManagerClient, MetricsReportingDisabled) { + TestingPrefServiceSimple local_state; + metrics::RegisterMetricsReportingStatePrefs(local_state.registry()); + local_state.registry()->RegisterBooleanPref( + metrics::prefs::kMetricsReportingEnabled, true); + + ChromeMetricsServicesManagerClient client(&local_state); + const metrics::EnabledStateProvider& provider = + client.GetEnabledStateProviderForTesting(); + + // Reporting should never be enabled + EXPECT_FALSE(provider.IsReportingEnabled()); +} diff --git a/test/BUILD.gn b/test/BUILD.gn index f1d1188d8ea1..9a3d5cc90dd3 100644 --- a/test/BUILD.gn +++ b/test/BUILD.gn @@ -66,6 +66,7 @@ test("brave_unit_tests") { "//brave/chromium_src/chrome/browser/history/history_utils_unittest.cc", "//brave/chromium_src/chrome/browser/signin/account_consistency_disabled_unittest.cc", "//brave/chromium_src/chrome/browser/ui/bookmarks/brave_bookmark_context_menu_controller_unittest.cc", + "//brave/chromium_src/components/metrics/enabled_state_provider_unittest.cc", "//brave/chromium_src/components/search_engines/brave_template_url_prepopulate_data_unittest.cc", "//brave/chromium_src/components/search_engines/brave_template_url_service_util_unittest.cc", "//brave/chromium_src/components/version_info/brave_version_info_unittest.cc",