Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to disable autocomplete #843

Closed
bsclifton opened this issue Aug 26, 2018 · 15 comments · Fixed by brave/brave-core#4033
Closed

Allow users to disable autocomplete #843

bsclifton opened this issue Aug 26, 2018 · 15 comments · Fixed by brave/brave-core#4033
Assignees
Labels
design A design change, especially one which needs input from the design team feature/url-bar priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include suggestion

Comments

@bsclifton
Copy link
Member

bsclifton commented Aug 26, 2018

Test plan

See brave/brave-core#4033

Description

Carried over from brave/browser-laptop#3631

Some users would like a discrete setting to disable autocomplete for the omnibox. I don't believe this is offered by Chromium/Chrome (you can only disable predictive services)

@bsclifton bsclifton added this to the Backlog milestone Aug 26, 2018
@tildelowengrimm tildelowengrimm added the priority/P3 The next thing for us to work on. It'll ride the trains. label Oct 31, 2018
@diracdeltas diracdeltas added priority/P4 Planned work. We expect to get to it "soon". and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Nov 6, 2018
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@alego500
Copy link

Leaving comment to show interest in this feature as well.

@Brave-Matt
Copy link

+1 from Community and definitely a +1 from myself:
https://community.brave.com/t/how-do-i-turn-off-url-auto-complete/62316

@edanyal
Copy link

edanyal commented May 24, 2019

Please!

@Brave-Matt
Copy link

+1 from Reddit, multiple users
https://www.reddit.com/r/brave_browser/comments/b4jn8t/autocomplete_delete/epo0wd1?utm_source=share&utm_medium=web2x

@crocket
Copy link

crocket commented Jul 21, 2019

auto-completion is a huge distraction. So, I turned it off in vivaldi web browser.
It's as distracting as smartphone notifications which I disabled except for the most important things.
Disabling auto-completion is good for maintaining focus.

@UsedToCould
Copy link

so are you guys gonna do something about this? you've been ignoring us for over a year.

@simonhong simonhong self-assigned this Nov 12, 2019
@mjlp224
Copy link

mjlp224 commented Nov 12, 2019

Please make disabling autocomplete an option. It would be a good feature since many people save login credentials whose pages could be easily navigated to through autocomplete & then have their private information accessed.

@simonhong
Copy link
Member

@mjlp224 Working on this for desktop :)

@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P4 Planned work. We expect to get to it "soon". labels Nov 13, 2019
@mjlp224
Copy link

mjlp224 commented Nov 15, 2019

Awesome thanks Simon good to see someone on it I've been following the topic for a while. How about mobile?

@simonhong
Copy link
Member

simonhong commented Nov 17, 2019

@rebron maybe disabling autocomplete on Mobile is another issue with this?

@rebron
Copy link
Collaborator

rebron commented Nov 20, 2019

@anthonypkeane for thoughts on disabling autocomplete suggestions via a mobile setting? We're doing this for desktop.

Also @simonhong related issue #5934 likely I can just dupe that issue to this one.

@rebron rebron added the design A design change, especially one which needs input from the design team label Nov 20, 2019
@rebron
Copy link
Collaborator

rebron commented Nov 20, 2019

Example of this setting in Firefox, we'll want to just disable autocomplete and not go this granularly with bookmarks, history, open tabs.
Screen Shot 2019-11-20 at 12 58 42 PM

@bsclifton
Copy link
Member Author

Updated labels and added milestone/test plan after brave/brave-core#4033 was merged 😄

@btlechowski
Copy link

btlechowski commented Jan 4, 2020

Verification passed on

Brave 1.3.81 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#4033.
Verified that autocomplete can be re-enabled.

image

image

Verification passed on

Brave 1.3.87 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Disable Autocomplete option:
image
image

Verification PASSED on macOS 10.15.2 x64 using the following build:

Brave 1.3.91 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS macOS Version 10.15.2 (Build 19C57)
  • ensured that Show autocomplete in address bar is being displayed under chrome://settings/appearance
  • ensured that Show autocomplete in address bar is enabled by default
  • ensured that disabling Show autocomplete in address bar doesn't show History, Bookmarks and current Opened Tabs in the omnibox when searching/typing

Screen Shot 2020-01-15 at 12 00 43 PM

@Amariithynar
Copy link

Is there a way to disable it autocompleting in the address bar directly and instead just offer suggestions? I WANT the suggestions, but I do NOT want it to shove it into my address bar!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team feature/url-bar priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include suggestion
Projects
None yet
Development

Successfully merging a pull request may close this issue.