Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crypto Wallets does not have latest proxy caching #7032

Closed
ryanml opened this issue Nov 20, 2019 · 1 comment · Fixed by brave/ethereum-remote-client#90
Closed

Crypto Wallets does not have latest proxy caching #7032

ryanml opened this issue Nov 20, 2019 · 1 comment · Fixed by brave/ethereum-remote-client#90
Assignees
@ryanml
Labels
feature/ethereum-remote-client QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
Ethereum Remote C...

Comments

@ryanml
Copy link
Contributor

ryanml commented Nov 20, 2019

It needs to pull in latest eth-json-rpc-infura, related to: #6614
@ryanml ryanml added the feature/web3/wallet Integrating Ethereum+ wallet support label Nov 20, 2019
@ryanml ryanml added this to the Ethereum Remote Client 1.0.13 milestone Nov 20, 2019
@ryanml ryanml self-assigned this Nov 20, 2019
@ryanml ryanml mentioned this issue Nov 20, 2019
Merged
This was referenced Nov 20, 2019
Closed
Closed
Closed
@srirambv
Copy link
Contributor

srirambv commented Nov 22, 2019 •
edited
Loading

Verification passed on

Brave 1.0.1 Chromium: 78.0.3904.108 (Official Build) (64-bit)
Revision 4b26898a39ee037623a72fcfb77279fce0e7d648-refs/branch-heads/3904@{#889}
OS Linux
Component 0.1.29
  • Verified using remote component 0.1.29
  • Verified console doesn't log any errors for transactions
  • Verified ETH/BAT is sent into a restored MM wallet
  • Verified ETH/BAT is sent into a restored Crypto Wallet
  • Verified sending conversion for ETH/ERC-20 tokens is correct
  • Verified buying via CW works on https://memefactory.io/ with transaction
    image

Verification PASSED on macOS 10.15.1 x64 using 1.0.1 Chromium: 78.0.3904.108 via https://github.com/brave/ethereum-remote-client/releases/tag/0.1.29.

  • Verified console doesn't log any errors for transactions
  • Verified ETH/BAT is sent into a restored MM wallet
  • Verified ETH/BAT is sent into a restored Crypto Wallet
  • Verified sending conversion for ETH/ERC-20 tokens is correct
  • Verified buying via CW works on https://memefactory.io/ with transaction

Screen Shot 2019-11-22 at 5 20 27 PM

Verification passed on

Brave 1.0.1 Chromium: 78.0.3904.108 (Official Build) (64-bit)
Revision 4b26898a39ee037623a72fcfb77279fce0e7d648-refs/branch-heads/3904@{#889}
OS Windows 10 OS Version 1903 (Build 18362.418)
Component 0.1.29
  • Verified console doesn't log any errors for transactions
  • Verified ETH/BAT is sent into a restored MM wallet
  • Verified ETH/BAT is sent into a restored Crypto Wallet
  • Verified sending conversion for ETH/ERC-20 tokens is correct
  • Verified buying via CW works on https://memefactory.io/ with transaction
    image

@srirambv srirambv added feature/ethereum-remote-client and removed feature/web3/wallet Integrating Ethereum+ wallet support labels Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryanml ryanml

Labels
feature/ethereum-remote-client QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
Ethereum Remote Client 0.1.29
Development

Successfully merging a pull request may close this issue.

Referencing direct eth-json-rpc-infura hash brave/ethereum-remote-client
3 participants
@kjozwiak @ryanml @srirambv