Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweekdeck doesn't load with Shields enabled (needs Cookies enabled) #6117

Closed
ryanbr opened this issue Sep 21, 2019 · 5 comments
Closed

Tweekdeck doesn't load with Shields enabled (needs Cookies enabled) #6117

ryanbr opened this issue Sep 21, 2019 · 5 comments
Labels
feature/shields/cookies Cookie controls implemented as part of Shields.

Comments

@ryanbr
Copy link

ryanbr commented Sep 21, 2019

Description

Visiting https://tweetdeck.twitter.com/ If sheilds is enabled, won't allow the user to use tweetdeck. Only working with Cookies is enabled.

Previous bug report;
#3495

Steps to Reproduce

  1. With Sheilds enabled (site cookies)
  2. Visiting https://tweetdeck.twitter.com/
  3. Expect tweetdeck screen
  4. Get a twitter login and then standard twitter page

Expected result:

Show tweetdeck correctly, not the standard twitter screen.

Reproduces how often:

Easily when sheilds is enabled / when cross-site cookies is enabled.

Brave version (brave://version info)

Version 0.68.139 Chromium: 77.0.3865.90 (Official Build) (64-bit)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
    Yes
  • Can you reproduce this issue with the beta channel?
    Yes
  • Can you reproduce this issue with the nightly channel?
    No.

Miscellaneous Information:

3 cookies are set from;
twitter.com
api.twitter.com
tweetdeck.twitter.com

Not sure how any of these are considered 3rd-party cookies

@ryanbr
Copy link
Author

ryanbr commented Sep 22, 2019

Confirmed with user, this isn't occurring in Nightly.

https://twitter.com/MBobnificent/status/1175630119865659392

@rebron
Copy link
Collaborator

rebron commented Oct 4, 2019

@ryanbr Is this working in other channels now or is there a specific fix we need to uplift?

@rebron rebron added the feature/shields/cookies Cookie controls implemented as part of Shields. label Oct 4, 2019
@rebron rebron changed the title Tweekdeck doesn't load with Sheilds enabled (needs Cookies enabled) Tweekdeck doesn't load with Shields enabled (needs Cookies enabled) Oct 4, 2019
@ryanbr
Copy link
Author

ryanbr commented Oct 4, 2019

Just confirming with the user via twitter, thanks for the reminder @rebron :)

It seems fine now. I was able to use tweetdeck

@kjozwiak
Copy link
Member

kjozwiak commented Oct 7, 2019

@rebron @ryanbr can we close this off?

@ryanbr
Copy link
Author

ryanbr commented Oct 7, 2019

Yup, resolved.

Fixed was removing all *.twitter.com from Preferences json then let Brave rebuild it again. Not sure caused the issue, but its resolved.

@ryanbr ryanbr closed this as completed Oct 7, 2019
@bbondy bbondy added this to the Closed / Invalid milestone Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/shields/cookies Cookie controls implemented as part of Shields.
Projects
None yet
Development

No branches or pull requests

4 participants