Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to tip when uphold password was recently changed #5906

Closed
btlechowski opened this issue Sep 5, 2019 · 6 comments
Closed

Unable to tip when uphold password was recently changed #5906

btlechowski opened this issue Sep 5, 2019 · 6 comments

Comments

@btlechowski
Copy link

Uphold will deny transaction when uphold password was changed within 1 day

Steps to Reproduce

  1. Go to uphold
  2. Change the password on KYCed account
  3. Connect the uphold account to Brave
  4. Tip a KYCed publisher (https://www.twitch.tv/neoness007)

Actual result:

Not able to tip the publisher due to recent password change
image (1)

Expected result:

cc @mandar-brave

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 0.69.124 Chromium: 76.0.3809.132 (Official Build) (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Ubuntu 18.04 LTS

Similar issue: #5884

cc @brave/legacy_qa @mandar-brave @NejcZdovc

@mandar-brave
Copy link

Need to get all exceptions from Uphold and handle them. This one should move user to disconnected state unless user verifies their new connection.

@NejcZdovc
Copy link
Contributor

if you change password uphold will send this error when you try to tip

{"code":"validation_failed","errors":{"user":[{"code":"password_reset_restriction","message":"The user password has been changed in the last 1 day","args":{"recentPasswordRestrictionEndDate":"2019-09-05T21:51:37.717Z","threshold":1,"unit":"day"}}]}}

@kjozwiak
Copy link
Member

kjozwiak commented Sep 5, 2019

@mandar-brave @rebron @NejcZdovc are we considering this a blocker or something that we want included for 0.69.x?

@mandar-brave
Copy link

no @kjozwiak we will release note it. Too late to handle exceptions; may be ask for a 0.70 uplift for this specific issue around handling password changes. I believe there are more exceptions that need handling beyond just password reset!

@NejcZdovc
Copy link
Contributor

@mandar-brave what should we display as an error, so that we can implement this one?

@NejcZdovc NejcZdovc added the priority/P3 The next thing for us to work on. It'll ride the trains. label Dec 5, 2019
@NejcZdovc NejcZdovc removed the bug label Mar 31, 2020
@NejcZdovc
Copy link
Contributor

closing as stale

@NejcZdovc NejcZdovc added closed/not-actionable and removed QA/Test-Plan-Specified QA/Yes priority/P3 The next thing for us to work on. It'll ride the trains. labels Apr 10, 2020
@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Apr 10, 2020
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants