-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support OS level targeting for ads #4761
Labels
feature/ads
priority/P2
A bad problem. We might uplift this to the next planned release.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
release-notes/include
Milestone
Comments
32 tasks
CI passed on all platforms other than macOS so restarting macOS |
Verified passed with
Verification is in-progress
Staging: Verification passed on
example from staging catalog: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature/ads
priority/P2
A bad problem. We might uplift this to the next planned release.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
release-notes/include
This is dependent on parsing the new catalog in #5231. CreativeSets now include a field for "oses" shows a list of OS levels (MACOS, IOS, LINUX, WINDOWS, ANDROID, ignore case). If this field is empty, assume all OSes are available. If the list is not empty, only show the ads in the creativeset if the current browser OS matches one given in the list.
The text was updated successfully, but these errors were encountered: