Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening link in new private window with Tor for first time leaves spurious new tab #4299

Open
riastradh-brave opened this issue May 4, 2019 · 0 comments
Labels
feature/tor OS/Desktop priority/P4 Planned work. We expect to get to it "soon".

Comments

@riastradh-brave
Copy link
Contributor

Description

If there is no private window with Tor presently open, then 'Open link in new private window with Tor' will create a window with two tabs: the new tab page, and the opened link. It should create only one tab, for the opened link.

Steps to Reproduce

  1. Open a fresh Brave instance with no private windows with Tor.
  2. Right-click on a link/bookmark and select 'Open link in new private window with Tor.'
  3. Hire Count von Count from Sesame Street to determine the number of tabs in the resulting private window with Tor.

Actual result:

There are two tabs in the new private window with Tor: one for the new tab page, and another for the opened link.

Expected result:

There should be only one tab in the new private window with Tor, for the link that was opened.

Reproduces how often:

100%

Brave version (brave://version info)

Brave 0.63.48 Chromium: 74.0.3729.108 (Official Build) (64-bit)
Revision daaff52abef89988bf2a26091062160b1482b108-refs/branch-heads/3729@{#901}
OS Linux
JavaScript V8 7.4.288.25
Flash (Disabled)
User Agent Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/74.0.3729.108 Safari/537.36
Command Line /usr/bin/brave-browser --enable-dom-distiller --disable-domain-reliability --disable-chrome-google-url-tracking-client --no-pings --enable-features=NewExtensionUpdaterService,DesktopPWAWindowing,fill-on-account-select --disable-features=AutofillServerCommunication,AudioServiceOutOfProcess,DefaultEnableOopRasterization,AutofillSaveCardSignInAfterLocalSave,NetworkService,UnifiedConsent --flag-switches-begin --flag-switches-end
Executable Path /opt/brave.com/brave/brave-browser
Profile Path /home/riastradh/.config/BraveSoftware/Brave-Browser/Profile 1
Variations c134752e-f685ead32c707b42-dcf7018a411b6d4e-3f4a17dfd01ab0d3-5ac89438927cedd-3f4a17dfb0271b40-360900151a0d11d4-2f9febdf16e0dd70-3f4a17df4b8c3f4-3f4a17dfb7e2524c-c92d551c411c711e-3f4a17df8f029c91-3f4a17df8982496f-3f4a17df61832c80-3f4a17dfcc20827f-77c422c591560a-29acad42db4845-ace4e1389853922b-3f4a17df7038b844-3f4a17df9ca1387e-3f4a17df776de70c-e0278d3ded9149a9-3f4a17df34d450b1-3f4a17dfd8343fa3-3f4a17dfb517d646-3f4a17df8ee5ed19-c3125ea274658432-fa79b94c9e201a2b-3f4a17df591576c8-3f4a17df5274eb09-3f4a17dfd6d4ee9a-3f4a17dfceff87ec-3f4a17dfdac832a5-3f4a17df44827ee5-3f4a17df3f79ac13-3d47f4f48f1e27f-3f4a17df5485fc4d-3f4a17df93731dca-ba4d7bd29b4c4257-3f4a17df8fa604e0-ace4e13843f62d3b-3f4a17df9e5c75f1-30e1b12b2594bdf4-3f4a17df6fa07eb4-7282ca762981bcb4-3f4a17df5139837c-3f4a17df4934552d-3f4a17df7f8176d9-3f4a17df9504402-3f4a17dff7217a71-b204717823a898eb-fc93cf747a5ba892-3f4a17dfd1cd70a5-3f4a17df4ea303a6-3f4a17dfac8d4708-5460eccbeb221b68-eb221b68b19465ab-b19465abe5373d71-e23a25d96e6e0c7e-3f17a7d895876445-2b71ffe42b33233e-881ca6c94da5ae82-3f4a17df56302f8c-2f882e70e3981599-f9910918fd56acdf-3f4a17df4750a89c-60f3cfdacec9a952-9a6c5085f56e0452-3f4a17df8576baf1-3f4a17dfd00fcbde-3f4a17df930e30f5-3f4a17df9a2f4e5b-9ded16b91354da85-f1a864dc494d8760-3f4a17dff9e5da91-508355f5fcdd9ed9-fcdd9ed985963571-859635713a4029d-d7f231f3b0ea13bc-3f4a17df47a2af3f-3f4a17df94e68624-803f8fc4cc73f8a1-3f4a17dfb4e8892d-a2d707c67e91b7bd-c6da37cb6204e469-3f4a17df41ddf744-c78ce173

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel?

all channels

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
    • no
  • Does the issue resolve itself when disabling Brave Rewards?
    • no
  • Is the issue reproducible on the latest version of Chrome?
    • N/A

Miscellaneous Information:

I laik to count. Ah ah ah ah ah.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/tor OS/Desktop priority/P4 Planned work. We expect to get to it "soon".
Projects
None yet
Development

No branches or pull requests

3 participants