-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Dark Mode & Tinted Icons on iOS 18 #41088
Comments
Would love a dark tint for Brave. Apple's doc / guidance is interesting as well. |
That was super quick thanks @kylehickinson !!! |
The above requires |
Does "or higher" include using the latest version of BraveBeta (1.71) from the AppStore? Unfortunately, I'm still seeing the white background on both the Beta 1.71(90) and Release 1.69.2(172) versions of Brave when using darkmode on iOS 18. These are the latest versions available at this time for both of these apps in the AppStore |
@kjmagill it does not include the beta builds as those have a different build schedule, the next beta build that gets uploaded will include these changes (90 currently does not include it) -- likely today/thursday |
Verified on
iPad Air / iPadOS 16.7.2STEPS:
ACTUAL RESULTS:
iPhone 14 / iOS 17.7STEPS:
ACTUAL RESULTS:
iPad Mni (6th gen) / iPadOS 18STEPS:
ACTUAL RESULTS:
|
iOS 18 adds support for specialized dark mode & tinted app icons and apps and we should add them since iOS 18 fails to generate a dark mode icon for Brave.
We'll need dark mode & tinted icons for these all 3 channels (release, beta, nightly), and optionally for local/debug builds
The text was updated successfully, but these errors were encountered: