Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Dark Mode & Tinted Icons on iOS 18 #41088

Closed
kylehickinson opened this issue Sep 16, 2024 · 6 comments · Fixed by brave/brave-core#25603
Closed

Support Dark Mode & Tinted Icons on iOS 18 #41088

kylehickinson opened this issue Sep 16, 2024 · 6 comments · Fixed by brave/brave-core#25603

Comments

@kylehickinson
Copy link
Collaborator

iOS 18 adds support for specialized dark mode & tinted app icons and apps and we should add them since iOS 18 fails to generate a dark mode icon for Brave.

We'll need dark mode & tinted icons for these all 3 channels (release, beta, nightly), and optionally for local/debug builds

@meguroyama
Copy link

Would love a dark tint for Brave. Apple's doc / guidance is interesting as well.

@meguroyama
Copy link

That was super quick thanks @kylehickinson !!!

@kjozwiak
Copy link
Member

The above requires 1.70.118 or higher for 1.70.x verification 👍

@kjmagill
Copy link

The above requires 1.70.118 or higher for 1.70.x verification 👍

Does "or higher" include using the latest version of BraveBeta (1.71) from the AppStore?

Unfortunately, I'm still seeing the white background on both the Beta 1.71(90) and Release 1.69.2(172) versions of Brave when using darkmode on iOS 18. These are the latest versions available at this time for both of these apps in the AppStore

@kylehickinson
Copy link
Collaborator Author

kylehickinson commented Sep 23, 2024

@kjmagill it does not include the beta builds as those have a different build schedule, the next beta build that gets uploaded will include these changes (90 currently does not include it) -- likely today/thursday

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Oct 1, 2024
@hffvld
Copy link
Contributor

hffvld commented Oct 1, 2024

Verified on iPad Air, iPhone 14 and iPad Mini (6th gen) using version(s):

Device/OS: 
- iPad Air / iPadOS 16.7.2
- iPhone 14 / iOS 17.7
- iPad Mni (6th gen) / iPadOS 18
Brave build: 1.70 (119)
BraveCore: 1.70.119 (129.0.6668.70)

iPad Air / iPadOS 16.7.2

STEPS:

  1. Follow the STR/TP from [iOS] Add dark & tinted mode icons for iOS 18 brave-core#25603 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that the standard light mode Brave icon appears on iOS 16

1 2
1 2
iPhone 14 / iOS 17.7

STEPS:

  1. Follow the STR/TP from [iOS] Add dark & tinted mode icons for iOS 18 brave-core#25603 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that the standard light mode Brave icon appears on iOS 17

1 2 3 4
1 2 3 4
iPad Mni (6th gen) / iPadOS 18

STEPS:

  1. Follow the STR/TP from [iOS] Add dark & tinted mode icons for iOS 18 brave-core#25603 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that the Brave icon supports Light, Dark, Automatic, and Tinted modes.
  • Verified that Brave icons appear correctly when using small and large icon settings in the customization panel.
  • Verified that using different tint configurations in Tinted mode is applied correctly.
  • Verified that the Brave icon shows the correct mode when using the automatic mode in the home screen customize menu.
  • Verified that Brave Widgets support the new Tinted mode.

1 2 3 4 5
1 2 3 4 5
1 2 3 4 5
1 2 3 4 5

@hffvld hffvld added QA Pass - iPhone QA Pass - iPad and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants