Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve VPN Country Server Details #39824

Closed
soner-yuksel opened this issue Jul 17, 2024 · 2 comments · Fixed by brave/brave-core#24806
Closed

Improve VPN Country Server Details #39824

soner-yuksel opened this issue Jul 17, 2024 · 2 comments · Fixed by brave/brave-core#24806

Comments

@soner-yuksel
Copy link

soner-yuksel commented Jul 17, 2024

Description

The number of server description under the city name does not represent the actual information related with it.

This should be changed with a text that can indicate the number of cities and number of servers which is working for the entire country.

The information can be fetched from Guardian SDK but it will require a version update.

This is reported by Guardian Team and asked if we can do a change around it.

31431231

@kjozwiak
Copy link
Member

kjozwiak commented Aug 6, 2024

The above requires 1.69.137 or higher for 1.69.x verification 👍

@hffvld
Copy link
Contributor

hffvld commented Aug 30, 2024

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.6.1
Brave build: 1.69 (160)
BraveCore: 1.69.160 (128.0.6613.114)

STEPS:

  1. Launch Brave
  2. Enable VPN
  3. Hamburger menu > VPN Region
  4. Disable Automatic toggle switch > Verify
  5. Find a country with 2 or more available cities > Tap the Info button
  6. Select any random city > Verify
  7. Hamburger menu > Settings
  8. Brave Firewall + VPN > Verify

ACTUAL RESULTS:

  • Verified that proper city and server numbers are shown on the Server Region page
  • Verified that choosing a specific city is working as expected
  • Verified that the correct country/city name is shown on the VPN settings page

1 2 3
1 2 3
1 2 3
1 2 3
1 2 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants