Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] - Use DarkReader for NightMode #39786

Closed
Brandon-T opened this issue Jul 16, 2024 · 1 comment · Fixed by brave/brave-core#24679
Closed

[iOS] - Use DarkReader for NightMode #39786

Brandon-T opened this issue Jul 16, 2024 · 1 comment · Fixed by brave/brave-core#24679
Assignees
@Brandon-T
Labels
feature-request OS/iOS Fixes related to iOS browser functionality QA Pass - iPad QA Pass - iPhone QA/Test-All-Platforms QA/Yes release-notes/include
Milestone
1.70.x - Release

Comments

@Brandon-T
Copy link

Platforms

iOS

Description

  • iOS should use DarkReader for night-mode as it works much better and is more customizable than the current NightMode script. It's also a Mozilla Approved Extension and Script.
@Brandon-T Brandon-T added QA/Yes release-notes/include feature-request OS/iOS Fixes related to iOS browser functionality labels Jul 16, 2024
@Brandon-T Brandon-T self-assigned this Jul 16, 2024
@Brandon-T Brandon-T mentioned this issue Jul 16, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.70.x - Nightly milestone Jul 31, 2024
@kjozwiak kjozwiak mentioned this issue Sep 25, 2024
Closed
19 tasks
@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Oct 10, 2024
@hffvld
Copy link
Contributor

hffvld commented Oct 10, 2024 •
edited
Loading

Verified on iPhone 14 and iPad Mini (6th gen) using version(s):

Device/OS: 
- iPhone 14 / iOS 17.7
- iPad Mni (6th gen) / iPadOS 18.0.1
Brave build: 1.70 (126)
BraveCore: 1.70.126 (129.0.6668.100)

STEPS:

  1. Launch Brave
  2. Hamburger menu > Settings
  3. Appearance > Enable Night Mode > Verify

ACTUAL RESULTS:

iPhone 14 / iOS 17.7
Night Mode is OFF Night Mode is ON Night Mode is OFF Night Mode is ON
1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4
iPad Mni (6th gen) / iPadOS 18.0.1
Night Mode is OFF Night Mode is ON Night Mode is OFF Night Mode is ON
1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4

@hffvld hffvld added QA Pass - iPhone QA Pass - iPad and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Oct 10, 2024
@Uni-verse Uni-verse mentioned this issue Oct 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Brandon-T Brandon-T

Labels
feature-request OS/iOS Fixes related to iOS browser functionality QA Pass - iPad QA Pass - iPhone QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Milestone
1.70.x - Release
Development

Successfully merging a pull request may close this issue.

[iOS] - DarkReader NightMode brave/brave-core
4 participants
@Brandon-T @kjozwiak @brave-builds @hffvld