Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leo - Hitting return on the keyboard should do a line break instead of sending message #39351

Closed
1 of 5 tasks
aguscruiz opened this issue Jun 25, 2024 · 2 comments · Fixed by brave/brave-core#24462
Closed
1 of 5 tasks
Assignees
Labels
browser-ai OS/iOS Fixes related to iOS browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - iPhone QA/Yes release-notes/include

Comments

@aguscruiz
Copy link

aguscruiz commented Jun 25, 2024

Description

When the user hits return on the iOS keyboard, there should be a line break instead of sending the message.
This will be a better user experience to let users craft their prompt in a more organized way.

The button should say "return" instead of "send".

To send a message, you'd have to hit the send button on the input.

Steps to reproduce


Actual result


Expected result


Reproduces how often

Easily reproduced

Brave version


Device/iOS version


Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

No response

@kjozwiak
Copy link
Member

kjozwiak commented Jul 5, 2024

The above requires 1.68.112 or higher for 1.68.x verification 👍

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jul 12, 2024
@hffvld
Copy link
Contributor

hffvld commented Jul 12, 2024

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.6
Brave build: 1.68 (117)
BraveCore: 1.68.117 (127.0.6533.26)

STEPS:

  1. Follow the STR/TP from fix(AIChat): Update return button for Leo on software keyboard for iOS brave-core#24462 (comment) and fix(AIChat): Update return button for Leo on software keyboard for iOS brave-core#24462 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that taping on Return via the OSK correctly created a new line.
  • Verified that taping on the Send button via Leo submitted the query to Leo via the panel.

1 2 3
1 2 3
2024-07-12_13-59-18.mp4

@hffvld hffvld added QA Pass - iPhone and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-ai OS/iOS Fixes related to iOS browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - iPhone QA/Yes release-notes/include
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

7 participants