Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Bitcoin Account Import on iOS #38546

Closed
StephenHeaps opened this issue May 24, 2024 · 1 comment · Fixed by brave/brave-core#23858
Closed

Support Bitcoin Account Import on iOS #38546

StephenHeaps opened this issue May 24, 2024 · 1 comment · Fixed by brave/brave-core#23858
Assignees
@StephenHeaps
Labels
feature/web3/wallet/bitcoin feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone X QA/Yes release-notes/include
Milestone
1.68.x - Release

Comments

@StephenHeaps
Copy link

Platforms

iOS

Description

Wallet's import account ui should support import of BTC accounts in format of zprv BIP84 extended keys.

https://learnmeabitcoin.com/technical/keys/hd-wallets/derivation-paths/#bip84

iOS front-end version of: #38446

Bitcoin Import
@StephenHeaps StephenHeaps added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/iOS Fixes related to iOS browser functionality front-end-change This task is a front end task and doesn't need any C++ changes feature/web3/wallet/bitcoin labels May 24, 2024
This was referenced May 24, 2024
Open
Merged
@StephenHeaps StephenHeaps changed the title Support Bitcoin account Import Support Bitcoin Account Import on iOS May 24, 2024
@jamesmudgett jamesmudgett moved this to Backlog in Web3 May 24, 2024
@StephenHeaps StephenHeaps moved this from Backlog to In Progress in Web3 May 27, 2024
@StephenHeaps StephenHeaps mentioned this issue May 27, 2024
Merged
24 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in Web3 May 31, 2024
@brave-builds brave-builds added this to the 1.68.x - Nightly milestone May 31, 2024
@StephenHeaps StephenHeaps mentioned this issue Jun 3, 2024
Closed
@srirambv
Copy link
Contributor

srirambv commented Jul 9, 2024

Verification passed on iPhone 13 with iOS 18.0 Beta running 1.68 (110)

  • Verified steps from brave/brave-core#23858
  • Verified able to import Bitcoin account via zprv private keys for BIP84 derivation
  • Verified when using xprv or yprv private keys account restore fails
  • Verified when imported m/84'/0'/0'/0/0 is imported as the account address
  • Verified accounts created for 6/12/15/21/24 seed words import via private key works as expected
  • Encountered #39637
38546.MP4

@Uni-verse Uni-verse mentioned this issue Sep 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StephenHeaps StephenHeaps

Labels
feature/web3/wallet/bitcoin feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone X QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.68.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): Support importing Bitcoin accounts on iOS brave/brave-core
3 participants
@StephenHeaps @srirambv @brave-builds