Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast info window needs to change to Brave #377

Closed
srirambv opened this issue Jun 18, 2018 · 2 comments
Closed

Cast info window needs to change to Brave #377

srirambv opened this issue Jun 18, 2018 · 2 comments

Comments

@srirambv
Copy link
Contributor

Description

Cast info window needs to change to Brave

Steps to Reproduce

  1. Right click on any tab
  2. Click on Cast
  3. Info modal says Chromium

Actual result:

cast

Expected result:

If the cast option is retained should show Brave and link to a Brave support page with details

Reproduces how often:

100%

Brave version (about:brave info)

Release build

#212

@simonhong
Copy link
Member

This is already fixed.

@btlechowski
Copy link

btlechowski commented Sep 21, 2018

Verification passed on

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows 7

Reported #1223 because hep link points to community.brave.com and not to a specific help page.

Verification Passed on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants